Conversation
hokupod
marked this pull request as ready for review
August 12, 2026 10:05
Author
|
@nikita-ashihmin I've resolved the conflicts with main and updated the validation results at head The CI and Conventional PRs runs show Could you also confirm whether |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Allow automation clients to create one-off ACP sessions backed by in-memory Codex threads. On
session/new,_meta.codex.ephemeral: trueis forwarded tothread/startasephemeral: true.Kyoso runs Codex reviewers through ACP and does not resume those review sessions. This opt-in lets such clients avoid retaining one-off reviews as persisted Codex tasks. The adapter needs to forward the storage choice when it creates the Codex thread; filtering the client's session list alone would not change thread persistence.
Compatibility
ephemeral: falsepreserves the existing persisted-session behavior.ephemeralvalues are rejected with ACPinvalidParamsbefore thread creation._meta.codexremain ignored.ThreadStartParams.ephemeralfield and requires no schema changes.Validation
Validated with upstream
mainateffb0fe670a49dfbb5071764b5f8a2e3c09e2393incorporated into headc9e698e86b0f88566ba31fcfe3688f2b5c5d5366:npm run typecheck— passed.npm test— 614 passed, 26 skipped, including opt-in, default/false compatibility, and invalid-value coverage.npm run build— passed.npm run bundle:allwith CI's Bun 1.3.11 — all six targets passed.git diff --check effb0fe670a49dfbb5071764b5f8a2e3c09e2393 HEAD— passed.run-codexrunner with ephemeral metadata —thread/startedreportedthread.path = null, and the prompt completed withend_turn. This was a focused smoke test; the full live-provider E2E suite was not run.GitHub CI and Conventional PRs currently report
action_requiredwith zero jobs; hosted checks have not run on this head.