feat(actortemplate): add per-template GoldenSnapshotWait#189
Open
Carlos Sanchez (carlossg) wants to merge 1 commit into
Open
feat(actortemplate): add per-template GoldenSnapshotWait#189Carlos Sanchez (carlossg) wants to merge 1 commit into
Carlos Sanchez (carlossg) wants to merge 1 commit into
Conversation
Replace the controller-wide ATE_GOLDEN_SNAPSHOT_WAIT env var with a per-workload spec field. Slow-booting workloads (e.g. Chromium under gVisor) can now set their own wait without forcing every template in the cluster to use the slowest boot budget.
Contributor
Eitan Yarmush (EItanya)
left a comment
Eitan Yarmush (EItanya)
left a comment
There was a problem hiding this comment.
Looks great, I was running into this issue as well
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an optional
goldenSnapshotWaitfield toActorTemplateSpecso each workload can control how long the controller waits between resuming the golden actor and taking its snapshot. Slow-booting workloads (e.g. Chromium under gVisor) need more than the 20-second default before their memory state is consistent enough to checkpoint; with this field they can set their own wait without forcing every template in the cluster to use the slowest boot budget.When unset, the controller falls back to the existing 20-second default.
Changes
ActorTemplateSpec.GoldenSnapshotWait *metav1.Duration(optional)defaultGoldenSnapshotWait = 20sgo generate