feat(router): make atenet timeouts configurable#179
Open
Falven (Falven) wants to merge 1 commit into
Open
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
951c2b5 to
bca32e7
Compare
Add CLI configuration for Envoy ext_proc, route, and actor resume timeout budgets so deployments can tune routing latency without code changes. Thread configured durations through xDS, ext_proc, and actor resume paths and cover defaults, overrides, and disabled route timeout in focused router tests.
bca32e7 to
93c0f9f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR makes the atenet router timeout budgets configurable while preserving the current defaults.
Motivation
Some actor resume paths can exceed the current hard-coded ext_proc and route budgets. When that happens, Envoy can time out request processing before the router finishes the resume path. Operators should be able to tune these budgets per environment without recompiling the router.
Implementation
--extproc-timeoutwith the existing5sdefault for Envoy ext_proc gRPC and message processing.--actor-resume-timeoutwith the existing15sdefault for actor resume calls made during request routing.--route-timeoutwith the existing10sdefault;0sdisables the Envoy route timeout.Related to #166.
Verification
GOTOOLCHAIN=go1.25.0+auto GOWORK=off go test ./cmd/atenet/internal/app/router