Add initial GOVERNANCE.md#169
Open
Tim Hockin (thockin) wants to merge 1 commit into
Open
Conversation
Collaborator
|
Looks good, reads well, internally consistent :) |
Davanum Srinivas (dims)
approved these changes
Jun 3, 2026
Comment on lines
+68
to
+69
| Open a PR. Allow at least one week for discussion. Requires Maintainer approval | ||
| to merge. |
There was a problem hiding this comment.
Not sure if you want to mention if there is different opinion among maitainers, how it should be resolved?
Collaborator
Author
There was a problem hiding this comment.
I'm trying to not be TOO prescriptive until there's really a need. I am a big believer is (near-)consensus when possible. Do you think it's critcal just yet?
|
lgtm overall, only left a small comment regarding updating the governance. |
f839e25 to
d3066ce
Compare
Collaborator
Author
|
Fixed most comments |
Contributor
|
FWIW, LGTM! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Taking over #11 - mostly I just tweaked Davanum Srinivas (@dims) work