Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changeset/fix-single-tilde-strikethrough.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
"@silicajs/core": patch
"@silicajs/assistant": patch
---

Disable GFM single-tilde strikethrough so `~text~` is not crossed out, matching Obsidian syntax.
2 changes: 1 addition & 1 deletion packages/assistant/src/ui/message.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ export function AssistantMessage({ message, onRetry }: AssistantMessageProps) {
{message.content ? (
<div className="prose prose-sm dark:prose-invert min-w-0 max-w-none break-words text-sm">
<ReactMarkdown
remarkPlugins={[remarkGfm]}
remarkPlugins={[[remarkGfm, { singleTilde: false }]]}
components={{ a: MarkdownLink }}
>
{message.content}
Expand Down
13 changes: 13 additions & 0 deletions packages/core/src/pipeline.test.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -411,6 +411,19 @@ describe("renderMarkdown", () => {
expect(html).toContain("<pre");
}, 15_000);

it("only treats double tildes as strikethrough", async () => {
const result = await renderMarkdown(
"~~crossed out~~ and ~not crossed~",
testContext("index", ["index"]),
);

const html = renderToStaticMarkup(<>{result.content}</>);

expect(html).toContain("<del>crossed out</del>");
expect(html).toContain("~not crossed~");
expect(html).not.toContain("<del>not crossed</del>");
}, 15_000);

it("sanitizes raw HTML and escapes OFM-injected labels", async () => {
const result = await renderMarkdown(
'[[<img src=x onerror=alert(1)>]]\n\n<script>alert(1)</script>\n\n<img src=x onerror=alert(1)>\n\n<h2 id="raw-id">Raw heading</h2>\n\n<h2 id="footnote-label">User heading</h2>',
Expand Down
9 changes: 6 additions & 3 deletions packages/core/src/pipeline/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,9 @@ import {
rehypeUnwrapSilicaEmbeds,
} from "./plugins.js";

/** Obsidian strikethrough uses `~~text~~`; single tildes are subscript, not delete. */
const remarkGfmOptions = { singleTilde: false } as const;

type MdastNode = {
type: string;
value?: string;
Expand Down Expand Up @@ -367,7 +370,7 @@ function baseProcessor(context: RenderContext) {
return unified()
.use(remarkParse)
.use(remarkFrontmatter, ["yaml"])
.use(remarkGfm)
.use(remarkGfm, remarkGfmOptions)
.use(remarkMath)
.use(remarkObsidian, { inlineTags: context.tags?.inline ?? true })
.use(remarkSilicaObsidian, context)
Expand All @@ -381,7 +384,7 @@ async function runRemarkObsidian(markdown: string, context: RenderContext) {
const processor = unified()
.use(remarkParse)
.use(remarkFrontmatter, ["yaml"])
.use(remarkGfm)
.use(remarkGfm, remarkGfmOptions)
.use(remarkMath)
.use(remarkObsidian, { inlineTags: context.tags?.inline ?? true })
.use(remarkSilicaObsidian, context);
Expand Down Expand Up @@ -413,7 +416,7 @@ function parsePlainTextMarkdown(markdown: string): MdastNode {
return unified()
.use(remarkParse)
.use(remarkFrontmatter, ["yaml"])
.use(remarkGfm)
.use(remarkGfm, remarkGfmOptions)
.use(remarkMath)
.use(remarkObsidian)
.parse(markdown) as MdastNode;
Expand Down