Repository navigation
Conversation
Branch coverage
49 files skipped due to complete coverage. |
7 tasks done
Lancetnik
added this pull request to stack #131
October 10, 2026 16:01
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Loading
screensfailed withAssertionErrorbefore an agent could save a Card instance or arrange a Screen. The custom runtime advertised script names through its descriptor but inherited AG2's instruction loader, which expects those scripts to be registered asMemorySkillcallables. Return the Screens instructions from its own runtime, matching the other built-in adapters while retaining skill availability filtering and script execution.Cards drawn through
rich-viewsalso stayed invisible in an already-open chat until it was reopened.createSurfacemounted an empty item, and subsequent layout/data events mutated the same object, leaving Svelte's derived layout unchanged. Publish a new surface item for streamed and durable updates while retaining its stable item/surface IDs, so the existing renderer updates immediately without duplicate Cards. Rebuild the committed SPA bundle.This PR is stacked on #139.
Related issue number
No linked issue; fixes the Screens loading failure and missing live Card rendering reproduced on the real local stand.
Validation
SkillPluginloading failed before the Screens fix and pass afterward. The gateway test now loads the skill before creating a source-backed instance and Screen, and verifies the retained layout after restart.http://127.0.0.1:8878; the existing chat and Screen remain accessible.Checks
ruff check .,ruff format --check ., andpytest -m "not integration"locally; all initially failing Python checks passed on the targeted rerun described above.web/, I rebuilt and committed the SPA bundle (npm --prefix web run build).AI assistance
Implementation, tests, and this description were prepared with Codex assistance.