Repository navigation
fix: correct AsciiQRCode matrix indexing and documentation class name - #64
Merged
Merged
Conversation
- Fix swapped x/y indices in AsciiQRCode.GetLineByLineGraphic (issue #52) - Update AsciiQRCodeRendererTests expected outputs to match corrected rendering - Rename ASCIIQRCode -> AsciiQRCode in README, README.pt-br, nuget-readme and AGENTS (issue #53) Co-Authored-By: Afonso Dutra Nogueira Filho <afonsoft@gmail.com>
afonsoft
self-requested a review
July 10, 2026 19:39
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
devin-ai-integration
Bot
force-pushed
the
devin/fix-ascii-readme
branch
from
July 10, 2026 19:43
63dea95 to
b3b5d9e
Compare
Qodana Community for .NET1272 new problems were found
💡 Qodana analysis was run in the pull request mode: only the changed files were checked View the detailed Qodana reportTo be able to view the detailed Qodana report, you can either:
To get - name: 'Qodana Scan'
uses: JetBrains/qodana-action@v2026.1.3
with:
upload-result: trueContact Qodana teamContact us at qodana-support@jetbrains.com
|
- Fix swapped x/y indices in AsciiQRCode.GetLineByLineGraphic (issue #52) - Update AsciiQRCodeRendererTests expected outputs to match corrected rendering - Rename ASCIIQRCode -> AsciiQRCode in README, README.pt-br, nuget-readme and AGENTS (issue #53) - Normalize test expected strings to avoid CRLF/LF mismatches on Windows Co-Authored-By: Afonso Dutra Nogueira Filho <afonsoft@gmail.com>
devin-ai-integration
Bot
force-pushed
the
devin/fix-ascii-readme
branch
from
July 10, 2026 19:49
b3b5d9e to
baf1a23
Compare
|
afonsoft
approved these changes
Jul 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


All Submissions:
Changes to Core Features:
Summary
Fixes two reported issues:
ASC is mistake! #52 — ASCII QR code rendering was incorrect.
AsciiQRCode.GetLineByLineGraphicwas readingModuleMatrix[x][y]instead ofModuleMatrix[y][x], producing a transposed/corrupted ASCII output. The matrix is row-major (List<BitArray>), so it must be indexed by row first, then column. Corrected the indexing and updated the expected outputs inAsciiQRCodeRendererTests.fix: documentaton (readme.md) #53 — Documentation used wrong class name. Replaced
ASCIIQRCodewithAsciiQRCodein:README.mdREADME.pt-br.mdQRCoder.Core/Assets/nuget-readme.mdAGENTS.mdVerification
All 498 tests pass on both frameworks. net48 tests were not executed because
monois unavailable locally.Link to Devin session: https://app.devin.ai/sessions/5682754ac3ea4a03a3edc50c84591a2d
Requested by: @afonsoft