Add responses messages main-chain tests#1071
Open
YueZh127 wants to merge 1 commit into
Open
Conversation
7e34006 to
0e6cc59
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Closes #668.
Responses/Messagesnow have several durable main-chain edge cases aroundprevious_response_id, tool result submission, caller scope/origin boundaries, and the Path B messages facade. This PR adds targeted regression tests for those gaps againstauto-refact-dev.Solution
/v1/responsestool output submission, including no durable tool-result/session side effects and no secret leakage.previous_response_iderror-path tests to assert structured error codes instead of string-only body checks.previous_response_idreuse under the same scope id but a different owner subject./v1/messagestool-result contract tests proving invalid assistant-side tool results are rejected and valid user-side tool results remain a stateless Path B facade.Impact Path
test/Aevatar.Hosting.Tests/MainnetResponsesEndpointsTests.cstest/Aevatar.Hosting.Tests/MainnetMessagesEndpointsTests.csThis is test-only. No production API, protocol, projection, or runtime behavior is changed.
Auto-Refact Integration
This branch is based on
origin/auto-refact-dev. During cherry-pick from the originalfeature/router-based #668 branch, the only conflict was inMainnetMessagesEndpointsTests.cs; the resolution keepsauto-refact-devcompletion recording and preserves the new #668 tool-result recording assertions.Validation
git diff --check HEAD~1..HEADpassed.bash tools/ci/test_stability_guards.shpassed.Aevatar.Hosting.Testsexecution is currently blocked locally during build by the existing systemprotocversion (libprotoc 3.11.4) rejecting existing proto3optionalfields. The failure occurs before these tests execute and is not caused by this PR.