Skip to content

fix(rust): address removal review feedback - #52

Merged
cdmurph32 merged 1 commit into
adobe:mainfrom
cdmurph32:removal_fixes
Nov 10, 2026
Merged

cdmurph32 merged 1 commit into
adobe:mainfrom
cdmurph32:removal_fixes

Conversation

@cdmurph32

Copy link
Copy Markdown
Collaborator

Summary

  • Preserve existing output access permissions during atomic replacement; keep new removal outputs private.
  • Preserve RGB/RGBA channel selection for PNG output in both CLI encode and remove paths.
  • Reduce removal allocations by consuming input images and reusing compatible float buffers.
  • Clarify removal-model startup and memory costs.

Metadata preservation and Python resize parity are out of scope.

Validation

  • 63 unit and documentation tests passed.
  • Six real-model removal tests passed.
  • Strict clippy, formatting, and diff checks passed.

(Sent by AI, with oversight)

Preserve output access permissions during atomic replacement and keep new removal outputs private. Retain RGB/RGBA channel selection, reuse owned removal buffers, and clarify model memory costs.
@cdmurph32
cdmurph32 merged commit 522e7cd into adobe:main Nov 10, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants