Repository navigation
Conversation
Submenus (B3 in the migration plan) are deferred and have not shipped in 2nd-gen, but the guide never mentioned them. A consumer migrating a menu that uses submenus would have followed the guide to completion and only then discovered the submenus were gone, along with their sp-menu-submenu-opened / sp-menu-submenu-closed listeners and any handleSubmenuOpened() / handleSubmenuClosed() calls. Adds submenus to the Removed table alongside the other unshipped features, calls the gap out up front so it is visible before any work starts, and adds the corresponding checklist items. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
The submenu warning was added as a second paragraph under the H1, but the consumer-migration-guide format is an H1 followed by exactly one sentence, and badge, popover, and tooltip all follow it. Fold the unshipped-feature caveat into the existing sentence instead. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
Rajdeepc
added
ready-for-review
Documentation
Component:Menu
Status:Ready for review
Rajdeepc
changed the title
Submenus belong to the menu-item follow-up, not the menu host guide: the migration plan moves them into swc-menu-item's own shadow tree (B3), and the guide's intro already scopes them out by noting that sp-menu-item, sp-menu-group, and sp-menu-divider have not migrated. The added row documented something the guide already covered, in the wrong guide. Restores migration-guide.mdx to its state from #6762. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Rajdeepc
changed the title
📚 Branch Preview Links🔍 Gen1 Visual Regression Test ResultsWhen a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:
Deployed to Azure Blob Storage: If the changes are expected, update the |
1 participant
Description
No net change. This branch currently carries no diff against
rajdeep/menu-migration.It was opened to close a suspected gap in the
swc-menuconsumer migration guide (submenus). That was wrong: the migration plan moves submenus intoswc-menu-item's own shadow tree (B3), so they belong to the menu-item follow-up, and the guide's intro already scopes them out by notingsp-menu-item,sp-menu-group, andsp-menu-dividerhave not migrated. The addition was reverted in 3f773f1.Motivation and context
Jira: [Menu] Establish component consumer migration guide.
The guide already exists at
2nd-gen/packages/swc/components/menu/migration-guide.mdx(added in #6762) and was audited against the migration plan's Must ship / Additive / Deferred / Disposition tables. No gaps remain in scope for the menu host. Submenus, menu-item, and menu-group are follow-ups.Held open as a placeholder rather than closed.
🤖 Generated with Claude Code