Repository navigation
Conversation
amuraru
approved these changes
Sep 27, 2026
Author
|
Hi @amuraru, friendly ping: this is approved and the checks pass. Is there anything else you need from me before it can be merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Since 0.16.x,
himl/config_generator.pycallslogging.basicConfig()and sets the root logger level at import time, soimport himlattaches a handler to the root logger and applications that configure their own handlers get duplicated log messages. This removes the module level configuration from the library module and configures logging in thehimlCLI entry point instead, so the CLI still prints its INFO messages.himl-config-mergerkeeps its existing configuration inconfig_merger.py.Fixes #210
Type of Change
Testing
Checklist
Additional Notes
The new test in
tests/test_main.pyimportshimlin a subprocess and checks that the root logger has no handlers; it fails before this change and passes after. On Windows, 6 tests intests/test_config_merger.pyfail both before and after this change (temp file locking and console encoding), all other tests pass.