Skip to content

fix(guides): keep sidekick library links pointing at the block collection - #1131

Open
dylandepass wants to merge 1 commit into
mainfrom
fix-sidekick-library-links
Open

dylandepass wants to merge 1 commit into
mainfrom
fix-sidekick-library-links

Conversation

@dylandepass

@dylandepass dylandepass commented Oct 6, 2026 •

Copy link
Copy Markdown
Member

The pipeline relativizes absolute aem.page/aem.live links, which turned the Sidekick Library link into a 404 on this site. Restore it to the sidekick-library branch (keeping the query string) next to the existing block-collection restore, and apply the restore to every link in main instead of only .content, which most sections do not have (e.g. /docs/faq).

Example link: https://sidekick-library--aem-block-collection--adobe.aem.page/tools/sidekick/library.html?plugin=blocks&path=/block-collection/embed&index=0, which the pipeline rewrites to /tools/sidekick/library.html?plugin=blocks&path=/block-collection/embed&index=0.

Notes:

  • The Sidekick Library only exists on the sidekick-library branch of the block collection (main returns 404), so that ref is hardcoded.
  • .content comes from section metadata. On /docs/faq only the hero section has it, so the previous .content a selector matched none of the page links (including the existing /block-collection/ rule). The restore now runs over main a[href].
  • target is still set on every link inside .content; outside .content it is only set on restored links, so other links on guides/skills pages are unchanged.
  • Restoration is skipped for links whose origin differs from the current page origin, and for links with an invalid URL.
  • Applies to the guides and skills templates, as before.

Test: new unit tests in tests/utils/helpers.test.js (including a fixture that mirrors the /docs/faq structure); npm run lint and npm test pass.

Preview: https://fix-sidekick-library-links--aem-website--adobe.aem.page/docs/faq

@aem-code-sync

aem-code-sync Bot commented Oct 6, 2026 •

Copy link
Copy Markdown

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run all PSI checks
  • Re-run failed PSI checks
  • Re-sync branch
Commits

…tion

The pipeline relativizes absolute aem.page/aem.live links, which turned the Sidekick Library link into a 404 on this site. Restore it to the sidekick-library branch (keeping the query string) next to the existing block-collection restore, and apply the restore to every link in main instead of only .content, which most sections do not have (e.g. /docs/faq).
@aem-code-sync

aem-code-sync Bot commented Oct 6, 2026

Copy link
Copy Markdown
Page Scores Audits Google
📱 /docs/faq PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /docs/faq PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@dylandepass
dylandepass requested a review from rofe October 6, 2026 18:16

This branch was successfully deployed

1 active deployment
fix-sidekick-library-links — ba18455c Deployed Oct 6, 2026 by aem-code-sync[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants