Repository navigation
feat(chat): support agentId to auto-select persona - #462
anfibiacreativa wants to merge 7 commits into
Conversation
Pass an optional agent-id attribute through NxChat → ChatController so the request body includes agentId, allowing da-agent to resolve a built-in or content-bus preset automatically. Co-authored-by: Cursor <cursoragent@cursor.com>
|
LGTM, but looks like you used an older main. Can you fix the conflicts. |
Co-authored-by: Cursor <cursoragent@cursor.com>
Conflict is solved |
| thinking: { type: Boolean }, | ||
| connected: { type: Boolean }, | ||
| toolCards: { type: Object }, | ||
| agentId: { type: String, attribute: 'agent-id' }, |
There was a problem hiding this comment.
Since this isnt used for rendering, why do we need to add it to the properties? Why not instead use getAttribute to pass it on?
There was a problem hiding this comment.
Good question, if agent-id stays purely as a one-time backend config, getAttribute() would be a reasonable simplification. My reasoning tho, and why I decided to go with a Lit property is because we may expect it to be a real component input: it already affects controller behavior, and it may also drive agent-specific UI/rendering later (I envision cases where the renderers are different per agent id). In that case, declaring it in static properties is the more idiomatic Lit pattern.
There was a problem hiding this comment.
Agreed for the future, but I would recommend holding off until we actually use it for rendering. Pre-emptively adding it means we re-render the component today for agentid changes for no benefit.
There was a problem hiding this comment.
+1 lets add this later if needed.
There was a problem hiding this comment.
done, dropped it from the reactive properties. we read agent-id once via getAttribute in connectedCallback now and removed the updated() handler, so no re-render on agent-id changes. happy to bring it back as a reactive prop if/when we actually drive rendering off it.
|
Please update the doc for any and all changes in the contract |
@sharanyavinod could you clarify which doc you suggest updated? on the da-nx side, this PR adds an optional agent-id attribute to and passes it through to the agent request. The backend contract for the new agentId request field is defined in the da-agent builtin-agent-presets PR, so I am not sure if you're asking for docs on the component API here or the agent request contract there. If helpful, I can also add a short comment/doc note here that agent-id is an optional embedding-time hint forwarded to the agent backend. |
Here https://github.com/adobe/da-nx/blob/main/docs/chat-ui-component.md - just to ensure the contracts there are up to date and any stale info is removed |
- read agent-id via getAttribute at mount instead of a reactive Lit property, avoiding needless re-renders when it changes - drop the updated() handler for agentId; the value is read once before mount - document the agent-id attribute and its request-body contract in chat-ui-component.md Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
updated docs/chat-ui-component.md, added an "Attributes in" section for agent-id and noted it's sent as agentId in the request body when set. |
# Conflicts: # WORKLOG.md
|
Checking in on this PR. It has been quiet for a while, so we have labeled it |
|
Final notice: this pull request will close in about 7 day(s) unless there is a reply or a new commit. If it is still relevant, just comment or remove the |
This branch was successfully deployed
4 participants
Summary
agent-idattribute toNxChatso embedding contexts can specify which persona the chat usesagentIdin the request body toda-agentfor automatic preset resolutionWhy
What Changed
nx2/blocks/chat/chat-controller.js: newsetAgentId(id)method; includesagentIdin POST body when setnx2/blocks/chat/chat.js: newagentIdLitElement property (reflected asagent-idattribute); forwards to controller on connect and on property change viaupdated()lifecycleSecurity
agentIdis not sensitive (it's a preset identifier like "skills-engineer")SAFE_AGENT_IDregex in da-agent prevents path traversal regardless of what the client sendsTest Plan
"agentId": "skills-engineer"agent-idattribute still works (noagentIdfield in body)agent-idat runtime updates the controlleragentIdfield when attribute is absent (not sent as empty string or null)Risks / Follow-ups
feat/builtin-agent-presets) to take effect