Repository navigation
Show/Hide password CSS - #112
Open
shravani-0811 wants to merge 3 commits into
Open
shravani-0811 wants to merge 3 commits into
shravani-0811 wants to merge 3 commits into
Conversation
rismehta
reviewed
Sep 16, 2026
rismehta
reviewed
Sep 16, 2026
rismehta
reviewed
Sep 16, 2026
rismehta
reviewed
Sep 16, 2026
rismehta
reviewed
Sep 16, 2026
rismehta
reviewed
Sep 16, 2026
rismehta
reviewed
Sep 16, 2026
sakshi-arora1
left a comment
Contributor
There was a problem hiding this comment.
The commit is confusing. As we are touching all the areas.
- Create a new commit to make variables, if you want to make it more variable driven. But you need to make sure the values remain same, as any change can actually break production forms.
- Create a separate commit for password
Checked the PR has 2 commits - with migration to variable in a separate commit - so we should be good. Also validated the variable replacement with copilot: so if we do not squash and merge - we should be good, and we can share the specific commit with customers to integrate the password changes in their repos. @sakshi-arora1 could you confirm if we are good to merge in that case. cc: @shravani-0811 |
Add $field-border-radius, $field-border-width, $validation-border-width, and $validation-inset-padding to _variables.scss, and migrate passwordinput and all other affected components to use them in place of repeated magic numbers (0.25rem, 1px, 4px, 5px) and the hardcoded #969696 color. This is a value-preserving refactor: rendered output is unchanged. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Correct the show/hide toggle button to reference the actual committed icon assets (showPassword.svg / hidePassword.svg) instead of the non-existent eye.svg / eye-off.svg, and align the toggle button's border-radius with the shared $field-border-radius value (0.2rem -> 0.25rem) to match the rest of the field styling. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
shravani-0811
force-pushed
the
password-component
branch
from
October 1, 2026 09:50
1121953 to
a1da60b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
Added Files for showing and hiding password as a toggle button
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: