Repository navigation
FORMS-28171: Backport reCAPTCHA v3 support (FORMS-27648) to release/650 - #2008
Open
kartikey19427 wants to merge 1 commit into
Open
kartikey19427 wants to merge 1 commit into
kartikey19427 wants to merge 1 commit into
Conversation
Backport of #1986 onto release/650: - RecaptchaImpl.getCaptchaDisplayMode() returns invisible for v3 so af-core's built-in submitForm auto-fetches the token. - Bump @aemforms/af-custom-functions 1.0.17 -> 1.0.18 (adds v3 support to fetchCaptchaToken; 1.0.18 is exactly 1.0.17 + the v3 change). - recaptcha widget/edit dialog treat v3 as invisible, score-based. - Guard container submit/save handlers against a missing state.events. - IT content (v3 cloud config + form), Cypress authoring/runtime coverage gated on FT_FORMS-27648, and FT enabled in IT toggle config. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Lighthouse scores (mobile)
|
Lighthouse scores (desktop)
|
Accessibility Violations Found
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Backport of #1986 (reCAPTCHA v3 support, FORMS-27648) to
release/650. The v3 changes were deliberately left out of the master→release/650 sync in #1991; this PR adds them back.RecaptchaImpl.getCaptchaDisplayMode()returnsinvisiblefor v3. af-core's built-insubmitForm(already in af-core 1.0.4, which release/650 uses) then fetches the token automatically.@aemforms/af-custom-functionsfrom1.0.17to1.0.18. 1.0.18 is exactly 1.0.17 plus the v3fetchCaptchaTokenchange (livecycle/af-custom-functions#15), so no separate custom-functions backport is needed.state.events.FT_FORMS-27648added to the IT toggle config, and Cypress authoring/runtime v3 tests gated onFT_FORMS-27648and the latest addon.Feature toggle: Kept (
FT_FORMS-27648), as FORMS-28171 asks.Adaptations: Conflicts were resolved by hand:
package-lock.json: only the af-custom-functions bump was kept.af-core-xfais not a release/650 dependency.recaptcha.runtime.cy.js: kept release/650'sFT_CLOUD_CONFIG_PROVIDERblock structure and added the v3 helper and tests next to it.Related Issue
https://jira.corp.adobe.com/browse/FORMS-28171 (backport of https://jira.corp.adobe.com/browse/FORMS-27648)
Companion PR (cq-guides, release/650): https://github.com/adobe-aem-forms/cq-guides/pull/7602
Motivation and Context
Adds the client/runtime side of reCAPTCHA v3 to 6.5. The server-side validation and cloud-config wizard come from the companion cq-guides PR.
How Has This Been Tested?
mvn -pl bundles/af-core -am test -Dtest=RecaptchaImplTest(JDK 11): 13/13 pass, including the new v3 URL and display-mode tests.FT_FORMS-27648enabled. The v3 submit tests need theRECAPTCHA_V3_API_KEYenv var.Types of changes
Checklist: