Add configurable request read timeout - #768
Open
mikelolasagasti wants to merge 2 commits into
Open
Conversation
Add a -max-body-size flag to optionally limit request body reads and return 413 for oversized requests. Keep the default at 0 to preserve existing unlimited behavior, but warn on startup when request body size is unlimited and document the production recommendation to configure a positive limit. Signed-off-by: Mikel Olasagasti Uranga <mikel@olasagasti.info>
Add a -read-timeout flag to optionally limit how long the server spends reading an incoming request, including the request body. Keep the default at 0 to preserve existing unlimited behavior, and document the production recommendation to configure a timeout alongside -max-body-size. Signed-off-by: Mikel Olasagasti Uranga <mikel@olasagasti.info>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dependent follow-up to #759.
This branch includes #759 as its first commit because the read-timeout change builds on that request-body-size work.
Please review only the second commit:
Add configurable request read timeout.It adds
-read-timeoutto configurehttp.Server.ReadTimeout, limiting how long clients may take to send the full request, including the body.After #759 lands, I can rebase this branch onto
masterso the PR contains only the timeout change.