Skip to content

test: fix non-constant Errorf format strings - #765

Open
mikelolasagasti wants to merge 1 commit into
adnanh:masterfrom
mikelolasagasti:fix-non-constant
Open

test: fix non-constant Errorf format strings#765
mikelolasagasti wants to merge 1 commit into
adnanh:masterfrom
mikelolasagasti:fix-non-constant

Conversation

@mikelolasagasti

Copy link
Copy Markdown

This change will solve future problems with newer Go releases:

go test ./...
# github.com/adnanh/webhook/internal/hook
# [github.com/adnanh/webhook/internal/hook]
internal/hook/hook_test.go:437:13: non-constant format string in call to (*testing.common).Errorf
internal/hook/hook_test.go:454:13: non-constant format string in call to (*testing.common).Errorf
ok  	github.com/adnanh/webhook	16.256s
FAIL	github.com/adnanh/webhook/internal/hook [build failed]
?   	github.com/adnanh/webhook/internal/middleware	[no test files]
ok  	github.com/adnanh/webhook/internal/pidfile	0.005s
?   	github.com/adnanh/webhook/test	[no test files]
FAIL

Signed-off-by: Mikel Olasagasti Uranga <mikel@olasagasti.info>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant