Repository navigation
Bump nanopb submodule to 0.4.9.2 - #218
Merged
Merged
Conversation
Fixes the pkg_resources ImportError in the Build and wrapper-generation workflows. Ref adafruit/Adafruit_Wippersnapper_Arduino#920
This was referenced Sep 16, 2026
brentru
approved these changes
Sep 21, 2026
Member
Author
|
Tested for v1 against prod in |
tyeth
added a commit
to tyeth/adafruit-Adafruit_Wippersnapper_Arduino
that referenced
this pull request
Oct 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps the
nanopbsubmodule from a 20210.4.5-devcommit to thenanopb-0.4.9.2release and dropssetuptoolsfrom the Build workflow.Why: master CI is red with
ModuleNotFoundError: No module named 'pkg_resources'(e.g. https://github.com/adafruit/Wippersnapper_Protobuf/actions/runs/35118154038). The old generator importspkg_resourcesunconditionally; setuptools 81+ removed it. The 0.4.9.2 generator usesimportlib.resources, so no setuptools is needed.Generated Arduino output: regenerated locally with 0.4.9.2 and compared against the current wrappers in https://github.com/adafruit/Adafruit_Wippersnapper_Arduino
main. Tags, sizes, init macros and field lists are identical; the only additions are the*_ENUMTYPEconvenience macros. Cosmetic differences: no timestamp line, shorter include guards, proto comments emitted,.pb.cincludes its header by bare name.Companion Arduino PR: adafruit/Adafruit_Wippersnapper_Arduino#993 (for adafruit/Adafruit_Wippersnapper_Arduino#920).
api-v2 equivalent: #219