Skip to content

Retry IDNA table allocation after a transient failure #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lemire merged 1 commit into from
Oct 14, 2026
Merged

Retry IDNA table allocation after a transient failure #108

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 15 additions & 4 deletions src/table_store.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,9 @@
// code; compression only affects on-disk size and one-time init.
//
// Thread-safe without mutex: atomic CAS + spin-wait. ensure_tables() returns
// false if initialization fails (OOM, corrupt blob); callers must treat that
// as a hard error and not touch table pointers.
// false if initialization fails. A corrupt blob stays failed for the process.
// An allocation failure is not latched: a later call tries again. Callers
// must treat a false return as a hard error and not touch table pointers.
#pragma once

#include "raw_inflate.hpp"
Expand Down Expand Up @@ -303,8 +304,12 @@ inline constexpr uint64_t kTablesSpinLimit = 1'000'000'000ull;
std::memory_order_acquire)) {
uint8_t* buffer = new (std::nothrow) uint8_t[table_blob::uncompressed_size];
if (buffer == nullptr) {
tables_init_state.store(kTablesFailed, std::memory_order_release);
// Leave the state uninitialized so a later call can retry. A corrupt
// blob (below) is permanent; running out of memory may not be.
// LCOV_EXCL_START
tables_init_state.store(kTablesUninit, std::memory_order_release);
return false;
// LCOV_EXCL_STOP
}

const size_t n = deflate::inflate_raw(table_blob::compressed,
Expand Down Expand Up @@ -376,9 +381,15 @@ inline constexpr uint64_t kTablesSpinLimit = 1'000'000'000ull;
if (state == kTablesReady) {
return true;
}
if (state == kTablesFailed) {
// Failed is permanent. Uninit means the peer gave up after a failed
// allocation: do not spin, the next call can take the init slot. One
// comparison, same shape as the old Failed check, so this wait loop does
// not grow the unity translation unit.
// LCOV_EXCL_START
if (state != kTablesInProgress) {
return false;
}
// LCOV_EXCL_STOP
#if defined(__x86_64__) || defined(_M_X64) || defined(__i386__) || \
defined(_M_IX86)
#if defined(__GNUC__) || defined(__clang__)
Expand Down
Loading