Skip to content

fix(scripts): Fix Orbit withdrawals script - #3605

Open
pxrl wants to merge 3 commits into
masterfrom
pxrl/fixOrbit
Open

fix(scripts): Fix Orbit withdrawals script#3605
pxrl wants to merge 3 commits into
masterfrom
pxrl/fixOrbit

Conversation

@pxrl

@pxrl pxrl commented Jul 21, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

@pxrl pxrl changed the title Pxrl/fix orbit fix(scripts): Fix Orbit withdrawals script Jul 21, 2026
@chatgpt-codex-connector

Copy link
Copy Markdown

💡 Codex Review

isDefined(ostiumUrl) ? new httpAdapter.AddressList({ name: "Ostium", path: ostiumUrl, logger }) : undefined,

P2 Badge Don't let Ostium failures drop the primary filter

When OSTIUM_ADDRESS_FILTER_URL is set and that endpoint times out or returns malformed JSON, this adapter uses the HTTP adapter's default throwOnError: true, so the combined AddressAggregator update rejects and Config.update retains a stale filter or, on startup, falls back to the local file only. That discards fresh Risk Labs addresses even if Risk Labs was available, so a single optional source outage can weaken filtering; make the Ostium adapter non-throwing or isolate failures per source.


OSTIUM_ADDRESS_FILTER_URL: ostiumUrl,

P1 Badge Document the new address-filter configuration

This introduces the OSTIUM_ADDRESS_FILTER_URL configuration, but the commit does not update any README.md or AGENTS.md. /workspace/relayer/AGENTS.md instructs contributors to keep relevant docs updated whenever configuration changes, and without that operators have no in-repo reference for enabling this source or understanding its startup/failure behavior.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant