CLI-1760: getSolrConfigSetId - MEO Support for Search Configuration Set.#1978
CLI-1760: getSolrConfigSetId - MEO Support for Search Configuration Set.#1978deepakmishra2 wants to merge 3 commits intomainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1978 +/- ##
=========================================
Coverage 92.37% 92.37%
- Complexity 1953 1956 +3
=========================================
Files 123 123
Lines 7082 7084 +2
=========================================
+ Hits 6542 6544 +2
Misses 540 540 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Try the dev build for this PR: https://acquia-cli.s3.amazonaws.com/build/pr/1978/acli.phar |
There was a problem hiding this comment.
Pull request overview
This PR addresses CLI-1760 by ensuring that, in MEO context where /applications/{uuid}/... requests are transparently rewritten to translation API endpoints, HAL _links are stripped from responses so translation API paths are not exposed to customers.
Changes:
- Extend
ApiBaseCommand’s_linksstripping condition to also cover/applications/...paths whenAH_CODEBASE_UUIDis set. - Add PHPUnit coverage verifying
_linksare removed for rewritten MEO application paths and preserved when not in MEO context.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
src/Command/Api/ApiBaseCommand.php |
Adds isRewrittenMeoPath() and uses it to decide when to munge responses by stripping _links. |
tests/phpunit/src/Commands/Api/ApiCommandTest.php |
Adds tests covering _links removal for rewritten MEO /applications/... paths and preservation outside MEO. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Motivation
Fixes CLI-1760
Proposed changes
TBD
Testing steps
AH_CODEBASE_UUID='your-codebase-uuid' acli api:applications:search:configuration-set-find 'applicationUuid' 'configurationSetId'