Skip to content

CLI-1760: getSolrConfigSetId - MEO Support for Search Configuration Set.#1978

Open
deepakmishra2 wants to merge 3 commits intomainfrom
CLI-1760
Open

CLI-1760: getSolrConfigSetId - MEO Support for Search Configuration Set.#1978
deepakmishra2 wants to merge 3 commits intomainfrom
CLI-1760

Conversation

@deepakmishra2
Copy link
Copy Markdown

@deepakmishra2 deepakmishra2 commented Apr 8, 2026

Motivation

Fixes CLI-1760

Proposed changes
TBD

Testing steps
AH_CODEBASE_UUID='your-codebase-uuid' acli api:applications:search:configuration-set-find 'applicationUuid' 'configurationSetId'

Copilot AI review requested due to automatic review settings April 8, 2026 10:22
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 8, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.37%. Comparing base (df40920) to head (184e533).

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #1978   +/-   ##
=========================================
  Coverage     92.37%   92.37%           
- Complexity     1953     1956    +3     
=========================================
  Files           123      123           
  Lines          7082     7084    +2     
=========================================
+ Hits           6542     6544    +2     
  Misses          540      540           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 8, 2026

Try the dev build for this PR: https://acquia-cli.s3.amazonaws.com/build/pr/1978/acli.phar

curl -OL https://acquia-cli.s3.amazonaws.com/build/pr/1978/acli.phar
chmod +x acli.phar

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses CLI-1760 by ensuring that, in MEO context where /applications/{uuid}/... requests are transparently rewritten to translation API endpoints, HAL _links are stripped from responses so translation API paths are not exposed to customers.

Changes:

  • Extend ApiBaseCommand’s _links stripping condition to also cover /applications/... paths when AH_CODEBASE_UUID is set.
  • Add PHPUnit coverage verifying _links are removed for rewritten MEO application paths and preserved when not in MEO context.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
src/Command/Api/ApiBaseCommand.php Adds isRewrittenMeoPath() and uses it to decide when to munge responses by stripping _links.
tests/phpunit/src/Commands/Api/ApiCommandTest.php Adds tests covering _links removal for rewritten MEO /applications/... paths and preservation outside MEO.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants