feat: add DX callsign lookup popup, rearrange DX target controls, simplify DX time#1085
Conversation
accius
left a comment
There was a problem hiding this comment.
Went through all three pieces. The lookup button wiring is right in both layouts (useCallsignPopup from #1068, anchor ref for positioning, disabled state when no callsign with proper title/aria variants), the header-row consolidation of DXCC/favorites/lock declutters the value row nicely, and letting the grid/callsign inputs flex instead of hard ch widths fixes the cramped feel at narrow panel sizes. Lang files are complete across all 16 locales and check-json-keys agrees.
One thing I want to call out explicitly so it's a conscious decision and not a drive-by: dropping the UTC/local toggle from DXLocalTime removes a piece of the #1038 feature that shipped in 26.4.0, along with its localStorage preference. I think the simplification is defensible since UTC is permanently visible in the header clock and the DX-local reading is the part with actual information content, and the solar-fallback ⚠ marker survives. But if anyone was using the toggle the old key just orphans silently. Fine with it going out this way; if we get complaints we know what to restore.
Tiny nit, take it or leave it: with disabled set on the lookup button, aria-disabled is redundant, and a disabled button drops out of the tab order entirely. Keyboard users with no DX callsign set won't discover the control exists. aria-disabled alone with a no-op click would keep it focusable. Not worth blocking a UI PR over.
K0CJH
What does this PR do?
Type of change
How to test
Checklist
var(--accent-cyan), etc.).bak,.old,console.logdebug lines, or test scripts includedScreenshots (if visual change)
Minimum desktop width looks like:
Normal size looks like: