Merge branch dev with rel-10.6 - #25787
Merged
Merged
Conversation
…bility-constraint Angular - Fixing the permission modal visibility constraint
voloagent
marked this pull request as ready for review
July 8, 2026 13:37
voloagent
approved these changes
Jul 8, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Automated merge from dev into rel-10.6, bringing over small Angular UI updates in the permission management package and a formatting/consistency adjustment in the core replaceable template directive.
Changes:
- Update
PermissionManagementComponentto synchronize thevisibleinput via an Angulareffect()anduntracked()(and refactor visibility logic intosetVisible). - Minor formatting/quoting cleanup for the
abpReplaceableTemplaterequired input definition inReplaceableTemplateDirective.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| npm/ng-packs/packages/permission-management/src/lib/components/permission-management.component.ts | Adds effect + untracked visibility synchronization and refactors visibility handling into setVisible. |
| npm/ng-packs/packages/core/src/lib/directives/replaceable-template.directive.ts | Formatting/consistency update for the input.required(...) alias definition and import list. |
Comment on lines
+312
to
+316
| // constructor() { | ||
| // effect(() => { | ||
| // this.setVisible(this.visibleInput()); | ||
| // }); | ||
| // } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR generated automatically to merge dev with rel-10.6. Please review the changed files before merging to prevent any errors that may occur.