fix(adk): skip unmaterializable transport objects - #168
Conversation
Classify an object whose ADT metadata cannot be loaded as unsupported, allowing exact components in the same transport to continue through ACR checkout.
🤖 CodeAnt AI — Review Status
|
Thanks for using CodeAnt! 🎉We're free for open-source projects. if you're enjoying it, help us grow by sharing. Share on X · |
✅ Deploy Preview for adt-cli canceled.
|
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
Warning Review limit reached
Next review available in: 30 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (6)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
MergerNeeds Review Filtered checkouts still retry Commit |
codeant-ai
Bot
added
the
size:XS
![amazon-q-developer[bot]](https://avatars.githubusercontent.com/in/1220912?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary
This PR correctly addresses the issue where OBJECT_METADATA_LOAD_FAILED errors were blocking transport materialization. The changes properly classify these errors as unsupported rather than failed, allowing transports to skip unmaterializable objects while continuing to process exact source components.
Changes Reviewed:
- ✅ Core logic change in
buildObjectEntriescorrectly classifies metadata load failures asunsupported - ✅ Test expectations updated to match the new behavior
- ✅ Documentation updated to clarify the handling of objects with unloadable ADT metadata
- ✅ All 192 ADK tests and 26 adt-flow tests passing
The implementation aligns with the design principle that objects explicitly classified as unsupported should be skipped with diagnostics rather than blocking the entire transport. No blocking issues identified.
You can now have the agent implement changes and create commits directly on your pull request's source branch. Simply comment with /q followed by your request in natural language to ask the agent to make changes.
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 5 |
| Duplication | 4 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
![codeant-ai[bot]](https://avatars.githubusercontent.com/in/646884?s=60&v=4){kind=small}
|
View your CI Pipeline Execution ↗ for commit 31bd06a
💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗ ☁️ Nx Cloud last updated this comment at |
…r path Co-Authored-By: Petr Plenkov <petr.plenkov@gmail.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
1 participant
User description
Summary
Classify OBJECT_METADATA_LOAD_FAILED as unsupported, so a transport can continue materializing exact source components when one object has no usable ADT metadata.
This directly fixes the failure shape in Booking ACR job 15849947781: PROG/ZI_FX_PST_CNTRL_CLS with OBJECT_METADATA_LOAD_FAILED.
Verification
Summary by cubic
Treat ADT metadata-load failures as unsupported so checkout skips those objects and continues materializing exact components. Applies to
adkmanifest building andadt-flowapplication component filtering.adk: manifest now classifies object metadata load errors asunsupported, skipping unmaterializable objects without reading source or changing paths.adt-flow: during application component filtering, skip objects with metadata-load failures without reloading metadata; ifloadObjectthrows anAdtFlowError, record them as skipped instead of failing checkout.Written for commit dabd37e. Summary will update on new commits.
CodeAnt-AI Description
Allow transport checkout to continue when an object's ADT metadata cannot be loaded
What Changed
Impact
✅ Fewer transport checkout failures✅ Exact components continue despite unusable object metadata✅ No repository changes for skipped objects💡 Usage Guide
Checking Your Pull Request
Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.
Talking to CodeAnt AI
Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:
This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.
Example
Preserve Org Learnings with CodeAnt
You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:
This helps CodeAnt AI learn and adapt to your team's coding style and standards.
Example
Retrigger review
Ask CodeAnt AI to review the PR again, by typing:
Check Your Repository Health
To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.