Angular Renderer Resilience & Reactivity Updates#1939
Merged
gspencergoog merged 1 commit intoJul 17, 2026
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request converts componentType and props to Angular Signals in ComponentHostComponent and introduces logic to wait for surface creation asynchronously if it is not immediately available. It also adds corresponding unit tests to verify these behaviors. The reviewer suggests refactoring the manual detectChanges() and Promise.resolve() change detection hacks by utilizing NgZone to handle asynchronous updates from outside the Angular Zone more idiomatically.
vikramsanthalia
force-pushed
the
fix-angular-resilience
branch
from
July 7, 2026 07:06
3b27e30 to
bddff1c
Compare
github-actions
Bot
added
the
status: needs-triage
josemontespg
left a comment
josemontespg
left a comment
Collaborator
There was a problem hiding this comment.
The changes make sense to improve reliability of Surface lookups during component tree creation. Left some comments about code style and testing
github-actions
Bot
removed
the
status: needs-triage
vikramsanthalia
force-pushed
the
fix-angular-resilience
branch
2 times, most recently
from
July 16, 2026 03:05
deab4aa to
0b43cb9
Compare
Contributor
Author
|
Hi @josemontespg, I have resolved the conflicts by rebasing the branch on top of I've also:
The PR checks are now green. Could you please take a look and merge the PR? Thanks! |
josemontespg
approved these changes
Jul 16, 2026
vikramsanthalia
force-pushed
the
fix-angular-resilience
branch
from
July 16, 2026 03:39
0b43cb9 to
32ea9b5
Compare
github-actions
Bot
added
the
status: needs-triage
vikramsanthalia
force-pushed
the
fix-angular-resilience
branch
3 times, most recently
from
July 17, 2026 16:08
57b43f0 to
632080f
Compare
This commit fixes critical reliability bugs and change-detection rendering skips in the Angular Renderer (ComponentHostComponent): 1. Fix subscription memory leak: Resolve a pattern where the component-host subscribes to onSurfaceCreated and attempts to unsubscribe self-referentially within the synchronous emission path, which evaluates to undefined and leaks listeners. 2. Asynchronous surface resolution: In progressive rendering or streaming environments, component host nodes can be mounted in the DOM before the surface itself is registered. Added a subscription to onSurfaceCreated to automatically bootstrap the component when the surface registers. 3. Optimize reactivity (Signals upgrade): Upgraded componentType and props to Signals. In strict OnPush applications, asynchronous updates inside RxJS callbacks were not recognized by the change detector, leaving components unrendered.
vikramsanthalia
force-pushed
the
fix-angular-resilience
branch
from
July 17, 2026 16:42
632080f to
27f32b2
Compare
josemontespg
enabled auto-merge (squash)
July 17, 2026 17:05
josemontespg
disabled auto-merge
July 17, 2026 17:05
gspencergoog
enabled auto-merge (squash)
July 17, 2026 17:17
gspencergoog
disabled auto-merge
July 17, 2026 17:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes critical reliability bugs and change-detection rendering skips in the Angular Renderer (
ComponentHostComponent):onSurfaceCreatedand attempts to unsubscribe self-referentially within the synchronous emission path, which evaluates toundefinedand leaks listeners.onSurfaceCreatedto automatically bootstrap the component when the surface registers.componentTypeandpropsto Angular Signals. In strictOnPushapplications, asynchronous updates inside RxJS callbacks were not recognized by the change detector, leaving components unrendered.Pre-launch Checklist