Repository navigation
Conversation
After storing issued credentials, ProvisioningService waited up to 3 s for the session's hot store to show as many new entries as it stored, and used the IDs it found. The hot store shows them only once it decoded the whole container again, which took 15 to 21 s on a device, so the result screen showed one of two issued credentials ("resolveNewStoreEntryIds timed out waiting for 2 new store entries, found 1").
PersistentSubjectCredentialStore now remembers the ID it assigned to each of the last stored entries, by identity, and WalletSubjectCredentialStore.storeEntryIdOf returns it for the entry that HolderAgent returns. Waiting for the hot store remains the fallback for an entry that is not known.
gp-iaik
force-pushed
the
fix/issued-store-entry-ids
branch
from
October 30, 2026 10:08
49b519f to
937e8b2
Compare
gp-iaik
changed the base branch from
feature/launchpad-2026-post
to
release/5.9.2-rc
October 30, 2026 10:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on
release/5.9.2-rc.On a device, issuing a PID as SD-JWT and mdoc at once showed only one of them on the result screen:
resolveNewStoreEntryIds timed out waiting for 2 new store entries, found 1. After storing,ProvisioningServicewaited up to 3 s for the session's hot store to show the new entries. The hot store shows them only once it has decoded the whole container again, which took 15–21 s on that device.Changes
PersistentSubjectCredentialStoreremembers the ID it assigned to each of the last 32 stored entries, looked up by identity (===).WalletSubjectCredentialStore.storeEntryIdOf(entry):nullby default;ProvisioningServicetakes the IDs of the entries thatHolderAgentreturns. These are the instances the store received.resumeWithAuthCode,loadCredentialWithOfferandkeepCredentialsUnderReview.Checks:
:androidApp:compileDebugKotlin,:shared:compileKotlinMetadataand:shared:testAndroidHostTest; all pass.StoreEntryIdTest: the IDs of two stored credentials match the container.Not done: issuing on a device; iOS.
🤖 Generated with Claude Code