Skip to content

Add fpga digital twins article - #100

Open
sernst-zch wants to merge 12 commits into
Zuehlke:mainfrom
sernst-zch:feature/fpga-digital-twins
Open

Add fpga digital twins article#100
sernst-zch wants to merge 12 commits into
Zuehlke:mainfrom
sernst-zch:feature/fpga-digital-twins

Conversation

@sernst-zch

Copy link
Copy Markdown

an article about FPGA engineering together with digital twins in python

@immo-huneke-zuhlke immo-huneke-zuhlke left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you might be able to use the footnote syntax in Markdown language: see https://github.blog/changelog/2021-09-30-footnotes-now-supported-in-markdown-fields/

I have run out of time and only got as far as "Reusing the python testbench". I'll try to pick this up again later, but in the meantime you might wish to pass the rest of the text through a style checker (e.g. copy and paste the rendered markdown to MS Word).

Comment thread drafts/fpga-digital-twins.md Outdated
Comment thread drafts/fpga-digital-twins.md Outdated
Comment thread drafts/fpga-digital-twins.md Outdated
Comment thread drafts/fpga-digital-twins.md Outdated
Comment thread drafts/fpga-digital-twins.md Outdated
Comment thread drafts/fpga-digital-twins.md Outdated
Comment thread drafts/fpga-digital-twins.md Outdated
Comment thread src/articles/fpga-digital-twins/index.md
Comment thread drafts/fpga-digital-twins.md Outdated
Comment thread drafts/fpga-digital-twins.md Outdated

@immo-huneke-zuhlke immo-huneke-zuhlke left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It reads much more fluently now. I have just two suggestions:

  • make sure cocotb is spelled consistently (currently the T is sometimes upper case)
  • the first time you mention cocotb, make it a hyperlink to the cocotb home page

@sernst-zch

Copy link
Copy Markdown
Author

Thanks for reviewing @immo-huneke-zuhlke ! I harmonized cocotb and Python, the hyperlink should already bee there on the first occurence of cocotb.

Comment thread src/articles/fpga-digital-twins/index.md
Comment thread drafts/fpga-digital-twins.md Outdated
Comment thread drafts/fpga-digital-twins.md Outdated
Comment thread drafts/fpga-digital-twins.md Outdated
Comment thread drafts/fpga-digital-twins.md Outdated
Comment thread src/articles/fpga-digital-twins/index.md
Comment thread drafts/fpga-digital-twins.md Outdated

## Conclusion

Digital twins can help to understand the core problem(s) and risks much faster and easier than straight VHDL coding from the beginning.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Digital twins can help to understand the core problem(s) and risks much faster and easier than straight VHDL coding from the beginning.
Digital twins can help to understand the core problems and risks much faster and easier than straight VHDL coding from the beginning.

Comment thread drafts/fpga-digital-twins.md Outdated
Comment thread drafts/fpga-digital-twins.md Outdated

@kunman93 kunman93 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just let me know if some of my findings are not clear.

@Nightmarius Nightmarius left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked out the article and it renders nicely and reads well.
While I can not comment on the code, the rest of the article seems ready.
Nice work!

We want to keep the FPGA resources and capabilities in mind.
A simple one-liner in Python might do the trick as well, but we wouldn't gain any insights into the resources needed in VHDL for this.

First, let's define a function prototype with the following parameter:

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
First, let's define a function prototype with the following parameter:
First, let's define a function prototype with the following parameters:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants