Repository navigation
Add support for the external_include_paths feature - #2
Merged
Merged
Conversation
Zer0-One
approved these changes
Nov 18, 2026
Owner
|
Before I merge this, do you think it warrants any kind of documentation in the README or anything? |
Collaborator
Author
|
Not sure, Bazel/rules_cc generally is awful at documenting the features it supports. I think it would be nice to have at least the noteworthy features documented, because right now you can only really find out about them by reading rules_cc's source code. I can add this to the README and we can make a pass and document the rest of the already-available features in a separate PR? |
Owner
Yeah, let's do that. |
robinlinden
force-pushed
the
external-include-paths-2
branch
from
November 20, 2026 21:59
39634b1 to
687a485
Compare
Collaborator
Author
|
Something like this? |
Owner
|
Yup, perfect |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a convenient way of disabling warnings from 3rd-party headers and allowing including them using angle brackets, especially now that Bazel 9 changes
cc_library'sincludes-attribute to add-Iincludes instead of-isystemones.See: bazelbuild/bazel@08936ae
(we've been using this in Hastur for ~10 months now)