Skip to content

Add support for the external_include_paths feature - #2

Merged
Zer0-One merged 2 commits into
Zer0-One:masterfrom
robinlinden:external-include-paths-2
Nov 20, 2026
Merged

Zer0-One merged 2 commits into
Zer0-One:masterfrom
robinlinden:external-include-paths-2

Conversation

@robinlinden

Copy link
Copy Markdown
Collaborator

This is a convenient way of disabling warnings from 3rd-party headers and allowing including them using angle brackets, especially now that Bazel 9 changes cc_library's includes-attribute to add -I includes instead of -isystem ones.

See: bazelbuild/bazel@08936ae

(we've been using this in Hastur for ~10 months now)

@robinlinden
robinlinden requested a review from Zer0-One November 18, 2026 00:40
@Zer0-One

Copy link
Copy Markdown
Owner

Before I merge this, do you think it warrants any kind of documentation in the README or anything?

@robinlinden

Copy link
Copy Markdown
Collaborator Author

Not sure, Bazel/rules_cc generally is awful at documenting the features it supports. I think it would be nice to have at least the noteworthy features documented, because right now you can only really find out about them by reading rules_cc's source code.

I can add this to the README and we can make a pass and document the rest of the already-available features in a separate PR?

@Zer0-One

Copy link
Copy Markdown
Owner

I can add this to the README and we can make a pass and document the rest of the already-available features in a separate PR?

Yeah, let's do that.

@robinlinden
robinlinden force-pushed the external-include-paths-2 branch from 39634b1 to 687a485 Compare November 20, 2026 21:59
@robinlinden

Copy link
Copy Markdown
Collaborator Author

Something like this?

@Zer0-One
Zer0-One merged commit 16d14e1 into Zer0-One:master Nov 20, 2026
3 checks passed
@Zer0-One

Copy link
Copy Markdown
Owner

Yup, perfect

@robinlinden
robinlinden deleted the external-include-paths-2 branch November 21, 2026 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants