Repository navigation
Conversation
|
@brightpedrofr-gif Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
…lt-escrow # Conflicts: # options_market/src/error.rs # options_market/src/events.rs # options_market/src/lib.rs # options_market/src/math.rs # options_market/src/storage.rs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes a griefing vector in
escrow_series_to_vaultandclaim_refund_from_vaultwhere untrusted vault addresses could be passed to zero series escrow without transferring funds.Key changes:
DataKey::Vaultto store the pinned trusted Vault contract address.set_vault(admin) andset_vault_via_multisigalong withvault_updatedevent.escrow_series_to_vaultvalidates the vault against the pinned vault address.vault.balance_of(series_id)increases by exactlyamount.DataKey::SeriesVault(series_id)to record per-series which vault holds its escrow so future rotations do not strand funds.claim_refund_from_vaultto validate against the series' recorded vault.Closes #7