Skip to content

πŸ›‘οΈ Sentinel: [HIGH] Fix command injection in wifi script#159

Open
ManupaKDU wants to merge 1 commit into
mainfrom
sentinel-fix-wifi-cmd-inject-14042704613632197757
Open

πŸ›‘οΈ Sentinel: [HIGH] Fix command injection in wifi script#159
ManupaKDU wants to merge 1 commit into
mainfrom
sentinel-fix-wifi-cmd-inject-14042704613632197757

Conversation

@ManupaKDU

Copy link
Copy Markdown

🚨 Severity: HIGH
πŸ’‘ Vulnerability: Command Injection. In package/network/config/wifi-scripts/files-ucode/usr/share/ucode/wifi/iface.uc, the prepare function interpolates num_global_macaddr and data.mbssid directly into an fs.popen() command string without prior validation.
🎯 Impact: If an attacker can control the wireless interface configuration, they can supply malicious shell metacharacters (e.g., ;, &, |) in the mbssid or num_global_macaddr fields, resulting in arbitrary shell command execution with root privileges.
πŸ”§ Fix: Mirrored the existing secure macaddr_base validation by checking that num_global_macaddr and data.mbssid contain only numeric digits (/[^0-9]/) before the fs.popen call, terminating the function with a warning if invalid characters are present.
βœ… Verification: Ran sh test_ci.sh to ensure no syntax errors or regressions were introduced in the full OpenWrt environment.

Signed-off-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>


PR created automatically by Jules for task 14042704613632197757 started by @manupawickramasinghe

Add regex validation for data.mbssid and num_global_macaddr in the
prepare function before interpolating them into fs.popen shell commands.
This prevents arbitrary shell command injection if user-provided wifi
configurations contain malicious shell characters.

Signed-off-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>

Co-authored-by: manupawickramasinghe <73810867+manupawickramasinghe@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant