π‘οΈ Sentinel: [CRITICAL] Fix command injection in wifi iface.uc#158
π‘οΈ Sentinel: [CRITICAL] Fix command injection in wifi iface.uc#158ManupaKDU wants to merge 1 commit into
Conversation
Add missing strict regex validation for `num_global_macaddr`, `mac_idx` and `data.mbssid` before they are interpolated into the `fs.popen()` shell command string. Signed-off-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com> Co-authored-by: manupawickramasinghe <73810867+manupawickramasinghe@users.noreply.github.com>
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
π¨ Severity: CRITICAL
π‘ Vulnerability: Command injection vulnerability in
package/network/config/wifi-scripts/files-ucode/usr/share/ucode/wifi/iface.ucviafs.popen()string interpolation.π― Impact: If
num_global_macaddrordata.mbssidare attacker-controlled and contain shell metacharacters, an attacker could execute arbitrary code on the OpenWrt system via thefs.popen()call.π§ Fix: Added strict regex validation
/[^0-9]/to ensurenum_global_macaddr,mac_idx, anddata.mbssidonly contain numeric digits before they are interpolated into the shell command string. (phyandmacaddr_basewere already validated by existing code).β Verification: Run
sh test_ci.shto confirm no regressions and ensure no arbitrary strings can pass the numeric validation blocks.Signed-off-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
PR created automatically by Jules for task 17529185373719667317 started by @manupawickramasinghe