Skip to content

πŸ›‘οΈ Sentinel: [CRITICAL] Fix command injection in wifi iface.uc#158

Open
ManupaKDU wants to merge 1 commit into
mainfrom
sentinel-fix-command-injection-17529185373719667317
Open

πŸ›‘οΈ Sentinel: [CRITICAL] Fix command injection in wifi iface.uc#158
ManupaKDU wants to merge 1 commit into
mainfrom
sentinel-fix-command-injection-17529185373719667317

Conversation

@ManupaKDU

Copy link
Copy Markdown

🚨 Severity: CRITICAL
πŸ’‘ Vulnerability: Command injection vulnerability in package/network/config/wifi-scripts/files-ucode/usr/share/ucode/wifi/iface.uc via fs.popen() string interpolation.
🎯 Impact: If num_global_macaddr or data.mbssid are attacker-controlled and contain shell metacharacters, an attacker could execute arbitrary code on the OpenWrt system via the fs.popen() call.
πŸ”§ Fix: Added strict regex validation /[^0-9]/ to ensure num_global_macaddr, mac_idx, and data.mbssid only contain numeric digits before they are interpolated into the shell command string. (phy and macaddr_base were already validated by existing code).
βœ… Verification: Run sh test_ci.sh to confirm no regressions and ensure no arbitrary strings can pass the numeric validation blocks.

Signed-off-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>


PR created automatically by Jules for task 17529185373719667317 started by @manupawickramasinghe

Add missing strict regex validation for `num_global_macaddr`, `mac_idx`
and `data.mbssid` before they are interpolated into the `fs.popen()`
shell command string.

Signed-off-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>

Co-authored-by: manupawickramasinghe <73810867+manupawickramasinghe@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant