Skip to content

🧪 scripts: add missing test for dl_github_archive.py error handling#135

Open
ManupaKDU wants to merge 1 commit into
mainfrom
add-dl-github-archive-tests-16598151936642151982
Open

🧪 scripts: add missing test for dl_github_archive.py error handling#135
ManupaKDU wants to merge 1 commit into
mainfrom
add-dl-github-archive-tests-16598151936642151982

Conversation

@ManupaKDU

Copy link
Copy Markdown

🎯 What: The error handling path in scripts/dl_github_archive.py where _hash_check(into) throws an exception within DownloadGitHubTarball.download() lacked test coverage.
📊 Coverage: Added a unit test validating that when the hash check fails, Path.rm_all(into) is invoked exactly once with the target path to clean up the archive, and the exception is appropriately re-raised.
Result: Improved test coverage and reliability for GitHub tarball fetching by validating its error recovery mechanism natively inside the test suite.

Signed-off-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>


PR created automatically by Jules for task 16598151936642151982 started by @manupawickramasinghe

This adds a test verifying that `Path.rm_all` is properly invoked and
the exception re-raised when `_hash_check` fails during a GitHub archive
download.

Signed-off-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>

Co-authored-by: manupawickramasinghe <73810867+manupawickramasinghe@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant