🧪 scripts: dl_cleanup: Add test for missing patchlevel IndexError in parseVer_123#118
🧪 scripts: dl_cleanup: Add test for missing patchlevel IndexError in parseVer_123#118ManupaKDU wants to merge 1 commit into
Conversation
Signed-off-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com> Co-authored-by: manupawickramasinghe <73810867+manupawickramasinghe@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
🎯 What: The testing gap in
scripts/dl_cleanup.pywhere the exception handling block forIndexErrorinsideparseVer_123(whenmatch.group(5)fails) was entirely untested.📊 Coverage: A new test class
TestDlCleanupParseVer123was added. It covers the scenario where a version string regex matches but lacks the 5th group (patchlevel), explicitly triggering theIndexErrorcode path via a mocked regex match object.✨ Result: Test coverage for
scripts/dl_cleanup.pyimproved by ensuring the fallback logic assigningpatchlevel = Noneand consequently evaluatingpatchlevelas0works correctly and safely without propagating exceptions.Signed-off-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
PR created automatically by Jules for task 5542137083509200070 started by @manupawickramasinghe