Skip to content

πŸ›‘οΈ Sentinel: [CRITICAL] Fix IDOR via hardcoded encryption key#27

Merged
manupawickramasinghe merged 1 commit into
developmentfrom
sentinel-hmac-token-migration-15256601571448637770
Jun 13, 2026
Merged

πŸ›‘οΈ Sentinel: [CRITICAL] Fix IDOR via hardcoded encryption key#27
manupawickramasinghe merged 1 commit into
developmentfrom
sentinel-hmac-token-migration-15256601571448637770

Conversation

@ManupaKDU

Copy link
Copy Markdown

🚨 Severity: CRITICAL
πŸ’‘ Vulnerability: Insecure Direct Object Reference (IDOR) via predictable symmetric encryption using a hardcoded universal secret key ("health") to protect URLs for sensitive patient reports in PatientReportController.
🎯 Impact: Anyone who knew the "health" key could decrypt or forge arbitrary report links and access sensitive patient data without authorization.
πŸ”§ Fix: Upgraded SMS patient report URLs to use secure, signed HMAC-SHA256 tokens (createBillToken/decodeBillToken). This validates both the authenticity and the expiration of the token. The insecure endpoint parsing method was updated to strictly validate the new token type while allowing legacy valid links to continue functioning via a backward-compatible check. The &user= query parameter used for expiration validation was removed from new SMS links as the expiration is now securely embedded within the HMAC token itself.
βœ… Verification: Ran mvn clean test to ensure no functionality is broken. Manually analyzed SecurityController implementation to ensure no compilation issues or logic bugs are introduced. Verified the new logic safely falls back for existing valid tokens.


PR created automatically by Jules for task 15256601571448637770 started by @manupawickramasinghe

Migrated patient report URL generation and parsing from insecure hardcoded symmetric encryption to secure, expiring HMAC tokens, while preserving backwards compatibility for previously sent links.

Co-authored-by: manupawickramasinghe <73810867+manupawickramasinghe@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@manupawickramasinghe manupawickramasinghe merged commit 1cf7d64 into development Jun 13, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants