π‘οΈ Sentinel: [CRITICAL] Fix IDOR via hardcoded encryption key#27
Conversation
Migrated patient report URL generation and parsing from insecure hardcoded symmetric encryption to secure, expiring HMAC tokens, while preserving backwards compatibility for previously sent links. Co-authored-by: manupawickramasinghe <73810867+manupawickramasinghe@users.noreply.github.com>
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
π¨ Severity: CRITICAL
π‘ Vulnerability: Insecure Direct Object Reference (IDOR) via predictable symmetric encryption using a hardcoded universal secret key ("health") to protect URLs for sensitive patient reports in
PatientReportController.π― Impact: Anyone who knew the "health" key could decrypt or forge arbitrary report links and access sensitive patient data without authorization.
π§ Fix: Upgraded SMS patient report URLs to use secure, signed HMAC-SHA256 tokens (
createBillToken/decodeBillToken). This validates both the authenticity and the expiration of the token. The insecure endpoint parsing method was updated to strictly validate the new token type while allowing legacy valid links to continue functioning via a backward-compatible check. The&user=query parameter used for expiration validation was removed from new SMS links as the expiration is now securely embedded within the HMAC token itself.β Verification: Ran
mvn clean testto ensure no functionality is broken. Manually analyzedSecurityControllerimplementation to ensure no compilation issues or logic bugs are introduced. Verified the new logic safely falls back for existing valid tokens.PR created automatically by Jules for task 15256601571448637770 started by @manupawickramasinghe