π‘οΈ Sentinel: [Enhancement] Enforce secure path resolution for system binaries#95
Conversation
Co-authored-by: ManupaKDU <95234271+ManupaKDU@users.noreply.github.com>
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
π¨ Severity: HIGH
π‘ Vulnerability: Privilege Escalation via PATH Interception. The application used
shutil.which('ping')which searches the default environmentPATH. In shared or misconfigured environments, an attacker could place a malicious executable namedpingin a user-writable directory that appears early in thePATH, causing the application to execute arbitrary code.π― Impact: Local Arbitrary Command Execution / Privilege Escalation.
π§ Fix: Enforced secure path resolution by explicitly passing a restricted, trusted
path="/bin:/usr/bin:/sbin:/usr/sbin"toshutil.which().β Verification: Ran
test_testping1.pyunit tests and visually verified network scanner runs locally.PR created automatically by Jules for task 14648094286107437454 started by @ManupaKDU