Skip to content

πŸ›‘οΈ Sentinel: [MEDIUM] Fix test suite SSRF mock bypass#94

Merged
manupawickramasinghe merged 1 commit into
mainfrom
sentinel/fix-mock-assertion-ssrf-16557653444664257341
Jun 13, 2026
Merged

πŸ›‘οΈ Sentinel: [MEDIUM] Fix test suite SSRF mock bypass#94
manupawickramasinghe merged 1 commit into
mainfrom
sentinel/fix-mock-assertion-ssrf-16557653444664257341

Conversation

@ManupaKDU

Copy link
Copy Markdown
Contributor

🚨 Severity: MEDIUM
πŸ’‘ Vulnerability: The test test_is_reachable_failure was using a private IP address (10.0.0.1). Because the application's SSRF filter blocks private IPs, it returned False immediately, bypassing the mocked subprocess.call. As a result, the test was silently passing without actually covering the intended subprocess failure branch.
🎯 Impact: The test suite was not correctly verifying the application's ability to handle network ping failures. Future refactors could break failure handling without triggering test regressions.
πŸ”§ Fix: Changed the mocked test IP to a globally routable public IP (8.8.4.4) to properly reach the subprocess call logic. Added mock_call.assert_called_once() to ensure the mock is always evaluated properly.
βœ… Verification: Ran python3 -m unittest test_testping1.py and confirmed all tests pass with the mock fully executing.


PR created automatically by Jules for task 16557653444664257341 started by @ManupaKDU

Added explicit mock assertions (`assert_called_once()`) to `test_is_reachable_failure` and `test_is_reachable_success` to prevent false positive test passes. Updated test IP to a globally routable address (`8.8.4.4`) to bypass SSRF logic correctly so that failure simulation path can be executed.

Co-authored-by: ManupaKDU <95234271+ManupaKDU@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@manupawickramasinghe manupawickramasinghe merged commit 84cf2b3 into main Jun 13, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants