Move private functions to -Internal module - #397
Open
Linschlager wants to merge 2 commits into
Open
Linschlager wants to merge 2 commits into
Linschlager wants to merge 2 commits into
Conversation
Linschlager
force-pushed
the
fix-private-function-references-pr
branch
from
August 25, 2026 09:48
7fa9f0d to
7f56e3b
Compare
Linschlager
changed the title
Linschlager
force-pushed
the
fix-private-function-references-pr
branch
from
August 25, 2026 13:42
92d47d5 to
23bafe5
Compare
Linschlager
force-pushed
the
fix-private-function-references-pr
branch
from
August 25, 2026 14:00
23bafe5 to
6d125ae
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On the Write.Fable module, some of the inlined functions are private. This is not per se an issue, as the function call is also scoped to the module which makes it valid.
However, the Fable compiler fails as it is more strict in that regard.
This is solved by making the relevant functions public on a different module. This way, the implementation is still not as visible and polluting the global namespace but it makes fable happy as the inline functions are not private anymore.
Also: Bumped fable to version 5.5 to show that it works on that version now.
This currently causes other issues because of the open PR here
Resolves #396