fix: Better handling of txs that send XRP + charge reserve#7671
Open
mvadari wants to merge 5 commits into
Open
fix: Better handling of txs that send XRP + charge reserve#7671mvadari wants to merge 5 commits into
mvadari wants to merge 5 commits into
Conversation
![xrplf-ai-reviewer[bot]](https://avatars.githubusercontent.com/u/67929741?s=60&v=4){kind=small}
oleks-rip
reviewed
Jun 30, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## xrplf/sponsor #7671 +/- ##
===============================================
- Coverage 82.2% 82.1% -0.1%
===============================================
Files 1016 1017 +1
Lines 78375 78200 -175
Branches 8996 9017 +21
===============================================
- Hits 64438 64217 -221
- Misses 13928 13974 +46
Partials 9 9
... and 29 files with indirect coverage changes 🚀 New features to boost your workflow:
|
oleks-rip
approved these changes
Jun 30, 2026
| ctx_.view(), | ||
| ctx_.tx, | ||
| sle, | ||
| balance - STAmount(amount).xrp(), |
Collaborator
There was a problem hiding this comment.
I see Payment Channel using preFeeBalance_ while Escrow uses sfBalance. Just want to check is this intended behavior?
Collaborator
Author
There was a problem hiding this comment.
That is how the code in develop works. But fair, fixed
PeterChen13579
approved these changes
Jun 30, 2026
PeterChen13579
left a comment
PeterChen13579
left a comment
Collaborator
There was a problem hiding this comment.
Please fix up tests before merging
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
This PR fixes
PaymentChannelCreateandEscrowCreateto properly handle sponsorship and reserves. They're a bit of a special case since they also can send XRP, which always comes from theAccount(never theSponsor).Context of Change
Sherlock 1680, issues found in the process of fixing that
See also: #6599
API Impact
N/A