Skip to content

support sponsor delegation integration#7665

Merged
yinyiqian1 merged 7 commits into
XRPLF:xrplf/sponsorfrom
yinyiqian1:delegate-sponsor
Jul 2, 2026
Merged

support sponsor delegation integration#7665
yinyiqian1 merged 7 commits into
XRPLF:xrplf/sponsorfrom
yinyiqian1:delegate-sponsor

Conversation

@yinyiqian1

@yinyiqian1 yinyiqian1 commented Jun 29, 2026

Copy link
Copy Markdown
Collaborator

High Level Overview of Change

  • SponsorshipTransfer is non-delegable
  • sfDelegate + reserve sponsor -> invalid
  • integrate delegation with sponsorship. checkSponsor and getFeePayer, use initiator. Because if the transaction contains sfDelegate, the Sponsorship object should be between the sponsor and the delegate.
  • sponsorFeeBalance lambda is moved to sponsor.h
  • remove sponsorFee sponsorReserve granular permissions

Context of Change

API Impact

  • Public API: New feature (new methods and/or new fields)
  • Public API: Breaking change (in general, breaking changes should only impact the next api_version)
  • libxrpl change (any change that may affect libxrpl or dependents of libxrpl)
  • Peer protocol change (must be backward compatible or bump the peer protocol version)

@yinyiqian1 yinyiqian1 marked this pull request as draft June 29, 2026 19:05
@yinyiqian1 yinyiqian1 force-pushed the delegate-sponsor branch 5 times, most recently from 5032aa0 to 82d23c3 Compare July 1, 2026 18:34
@yinyiqian1 yinyiqian1 marked this pull request as ready for review July 1, 2026 18:36
@codecov

codecov Bot commented Jul 1, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.5%. Comparing base (ad5bc87) to head (49418ec).
⚠️ Report is 1 commits behind head on xrplf/sponsor.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff               @@
##           xrplf/sponsor   #7665     +/-   ##
===============================================
- Coverage           82.5%   82.5%   -0.0%     
===============================================
  Files               1034    1034             
  Lines              79898   79898             
  Branches            9012    9014      +2     
===============================================
- Hits               65921   65917      -4     
- Misses             13968   13972      +4     
  Partials               9       9             
Files with missing lines Coverage Δ
include/xrpl/protocol/detail/permissions.macro 100.0% <ø> (ø)
include/xrpl/protocol/detail/transactions.macro 100.0% <ø> (ø)
...rotocol_autogen/transactions/SponsorshipTransfer.h 100.0% <ø> (ø)
src/libxrpl/tx/Transactor.cpp 90.8% <100.0%> (+<0.1%) ⬆️

... and 4 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions

github-actions Bot commented Jul 1, 2026

Copy link
Copy Markdown

This PR has conflicts, please resolve them in order for the PR to be reviewed.

@mvadari mvadari requested review from Kassaking7 and mvadari July 1, 2026 22:14
@github-actions

github-actions Bot commented Jul 2, 2026

Copy link
Copy Markdown

All conflicts have been resolved. Assigned reviewers can now start or resume their review.

@Kassaking7 Kassaking7 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yinyiqian1 yinyiqian1 merged commit 11e6d65 into XRPLF:xrplf/sponsor Jul 2, 2026
80 of 81 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants