refactor: Move SponsorshipTransfer code around, add some comments#7662
Merged
Conversation
![depthfirst-app[bot]](https://avatars.githubusercontent.com/in/1021002?s=60&v=4){kind=small}
![xrplf-ai-reviewer[bot]](https://avatars.githubusercontent.com/u/67929741?s=60&v=4){kind=small}
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## xrplf/sponsor #7662 +/- ##
===============================================
- Coverage 82.2% 82.1% -0.1%
===============================================
Files 1016 1017 +1
Lines 78375 78196 -179
Branches 8996 9012 +16
===============================================
- Hits 64438 64228 -210
- Misses 13928 13959 +31
Partials 9 9
... and 12 files with indirect coverage changes 🚀 New features to boost your workflow:
|
PeterChen13579
approved these changes
Jun 30, 2026
PeterChen13579
left a comment
PeterChen13579
left a comment
Collaborator
There was a problem hiding this comment.
looks good to me; I have one small comment regarding the hardcoded numbers, I'm okay if you fix or not to.
yinyiqian1
approved these changes
Jun 30, 2026
|
This PR has conflicts, please resolve them in order for the PR to be reviewed. |
… mvadari/sponsor/transfer
|
All conflicts have been resolved. Assigned reviewers can now start or resume their review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
Title pretty much says it all, no functionality change
Context of Change
An initial cut of some refactor efforts
API Impact
N/A