Skip to content

refactor: Add ReserveTxContext to ApplyViewContext#7661

Open
mvadari wants to merge 17 commits into
mvadari/sponsor/apply-view-contextfrom
mvadari/sponsor/reserve-context
Open

refactor: Add ReserveTxContext to ApplyViewContext#7661
mvadari wants to merge 17 commits into
mvadari/sponsor/apply-view-contextfrom
mvadari/sponsor/reserve-context

fix clang-tidy

8703d10
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jun 30, 2026 in 1s

82.2% (target 75.0%)

View this Pull Request on Codecov

82.2% (target 75.0%)

Details

Codecov Report

❌ Patch coverage is 98.88889% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.2%. Comparing base (4cbc050) to head (8703d10).
⚠️ Report is 4 commits behind head on mvadari/sponsor/apply-view-context.

Files with missing lines Patch % Lines
src/libxrpl/tx/paths/MPTEndpointStep.cpp 80.0% 2 Missing ⚠️
src/libxrpl/ledger/ApplyView.cpp 95.0% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                        Coverage Diff                         @@
##           mvadari/sponsor/apply-view-context   #7661   +/-   ##
==================================================================
  Coverage                                82.1%   82.2%           
==================================================================
  Files                                    1016    1016           
  Lines                                   78233   78295   +62     
  Branches                                 9003    9007    +4     
==================================================================
+ Hits                                    64267   64330   +63     
+ Misses                                  13957   13956    -1     
  Partials                                    9       9           
Files with missing lines Coverage Δ
include/xrpl/ledger/ApplyView.h 97.6% <100.0%> (+0.4%) ⬆️
include/xrpl/ledger/helpers/AccountRootHelpers.h 100.0% <ø> (ø)
include/xrpl/ledger/helpers/EscrowHelpers.h 98.9% <100.0%> (-<0.1%) ⬇️
include/xrpl/ledger/helpers/NFTokenHelpers.h 100.0% <ø> (ø)
include/xrpl/ledger/helpers/SponsorHelpers.h 100.0% <ø> (+2.2%) ⬆️
include/xrpl/tx/ApplyContext.h 100.0% <100.0%> (ø)
src/libxrpl/ledger/View.cpp 96.8% <100.0%> (-<0.1%) ⬇️
src/libxrpl/ledger/helpers/AccountRootHelpers.cpp 88.4% <100.0%> (+0.4%) ⬆️
src/libxrpl/ledger/helpers/CredentialHelpers.cpp 98.3% <100.0%> (ø)
src/libxrpl/ledger/helpers/MPTokenHelpers.cpp 96.5% <100.0%> (+<0.1%) ⬆️
... and 41 more

... and 7 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.