Skip to content

chore: Enable most cppcoreguidelines checks#7660

Open
mathbunnyru wants to merge 2 commits into
XRPLF:developfrom
mathbunnyru:enable_cppcore
Open

chore: Enable most cppcoreguidelines checks#7660
mathbunnyru wants to merge 2 commits into
XRPLF:developfrom
mathbunnyru:enable_cppcore

Conversation

@mathbunnyru

Copy link
Copy Markdown
Contributor

High Level Overview of Change

Enabling all cppcoreguidelines checks for now, will remove some, if they're too noisy.

Context of Change

API Impact

  • Public API: New feature (new methods and/or new fields)
  • Public API: Breaking change (in general, breaking changes should only impact the next api_version)
  • libxrpl change (any change that may affect libxrpl or dependents of libxrpl)
  • Peer protocol change (must be backward compatible or bump the peer protocol version)

@codecov

codecov Bot commented Jun 29, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.3%. Comparing base (809a629) to head (e9594ac).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           develop   #7660     +/-   ##
=========================================
- Coverage     82.3%   82.3%   -0.0%     
=========================================
  Files         1024    1024             
  Lines        78389   78389             
  Branches      8973    8976      +3     
=========================================
- Hits         64503   64496      -7     
- Misses       13877   13884      +7     
  Partials         9       9             

see 10 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant