fix: Add defensive error check to mpt_get_send_context_hash#7659
Open
ManimaranRepos wants to merge 2 commits into
Open
fix: Add defensive error check to mpt_get_send_context_hash#7659ManimaranRepos wants to merge 2 commits into
ManimaranRepos wants to merge 2 commits into
Conversation
|
If only the most recent commit is unsigned, you can run:
If multiple commits are unsigned, you can run:
If you're new to commit signing, there are different ways to set it up: Sign commits with
|
- Add error checking to getSendContextHash() function - Return error if mpt_get_send_context_hash() fails - Add period to tecBAD_PROOF error message for consistency Fixes XRPLF#7651 Signed-off-by: Manimaran <smanimarancse@gmail.com>
f68b2dd to
afff396
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds defensive error checking to the
getSendContextHash()function to properly handle failures from the underlyingmpt_get_send_context_hash()C library function.Changes
getSendContextHash()in ConfidentialTransfer.cpptecBAD_PROOFerror message for consistencyFixes #7651