Skip to content

host function error path refactor#7639

Open
pwang200 wants to merge 1 commit into
ripple/wasmi-host-functionsfrom
ripple/wasmi-host-functions-return
Open

host function error path refactor#7639
pwang200 wants to merge 1 commit into
ripple/wasmi-host-functionsfrom
ripple/wasmi-host-functions-return

Conversation

@pwang200

Copy link
Copy Markdown
Collaborator

No description provided.

@xrplf-ai-reviewer xrplf-ai-reviewer Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean refactor - nothing to flag.

Review by Claude Sonnet 4.6 · Prompt: V15

@pwang200 pwang200 force-pushed the ripple/wasmi-host-functions-return branch from 3e6946e to df0dd88 Compare June 25, 2026 22:43

@xrplf-ai-reviewer xrplf-ai-reviewer Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Case mismatch between the trap-message constant and the comment example — see inline; could cause tecINTERNAL to be misclassified as tecFAILED_PROCESSING.

Review by Claude Sonnet 4.6 · Prompt: V15

Comment thread include/xrpl/tx/wasm/WasmCommon.h
@pwang200 pwang200 force-pushed the ripple/wasmi-host-functions-return branch from df0dd88 to 83279ee Compare June 25, 2026 22:54

@xrplf-ai-reviewer xrplf-ai-reviewer Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Review by Claude Sonnet 4.6 · Prompt: V15

@pwang200 pwang200 requested a review from oleks-rip June 25, 2026 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant