test: Add test for account objects#7625
Open
kuznetsss wants to merge 2 commits into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #7625 +/- ##
=======================================
Coverage 82.0% 82.0%
=======================================
Files 1007 1007
Lines 76890 76890
Branches 8971 8966 -5
=======================================
Hits 63050 63050
Misses 13831 13831
Partials 9 9 see 3 files with indirect coverage changes 🚀 New features to boost your workflow:
|
a1q123456
requested changes
Jun 29, 2026
| seqs.reserve(numEntries); | ||
| for ([[maybe_unused]] auto _ : std::ranges::iota_view{0, numEntries}) | ||
| { | ||
| json::Value params; |
Contributor
There was a problem hiding this comment.
can we add calls to testcase() to describe what each section is testing which rpc command?
| void | ||
| testAccountObjectDoesntShowCancelledOffers() | ||
| { | ||
| testcase("AccountObjectDoesntShowCancelledOffers"); |
Contributor
There was a problem hiding this comment.
This test case name doesn't seem to be very human-readable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
Add a test case for account objects checking it doesn't show cancelled offers.
Context of Change
API Impact
libxrplchange (any change that may affectlibxrplor dependents oflibxrpl)