refactor: Use ApplyViewContext everywhere instead of ApplyView+STTx by mvadari · Pull Request #7618 · XRPLF/rippled

mvadari · 2026-06-24T23:51:28Z

High Level Overview of Change

This PR adds a new tiny struct, ApplyViewContext, that's just ApplyView+STTx, that can be passed around more easily than ApplyView+STTx separately as parameters. It should be used in place of all ApplyView parameters in helpers.

Context of Change

Adding an extra tx parameter is a bit messy

Future Tasks

Long term, once #7404 is merged, we can switch this to just use ApplyContext directly. But to avoid that being a blocker for Sponsor, we're doing this instead temporarily.

codecov · 2026-06-25T01:27:26Z

Codecov Report

❌ Patch coverage is 94.84536% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.1%. Comparing base (494391b) to head (4cbc050).
⚠️ Report is 17 commits behind head on xrplf/sponsor.

Files with missing lines	Patch %	Lines
src/libxrpl/tx/transactors/vault/VaultDeposit.cpp	33.3%	2 Missing ⚠️
.../libxrpl/tx/transactors/token/MPTokenAuthorize.cpp	0.0%	1 Missing ⚠️
src/libxrpl/tx/transactors/vault/VaultCreate.cpp	87.5%	1 Missing ⚠️
src/libxrpl/tx/transactors/vault/VaultWithdraw.cpp	83.3%	1 Missing ⚠️

Additional details and impacted files

@@               Coverage Diff               @@
##           xrplf/sponsor   #7618     +/-   ##
===============================================
- Coverage           82.2%   82.1%   -0.1%     
===============================================
  Files               1016    1016             
  Lines              78375   78233    -142     
  Branches            8996    9003      +7     
===============================================
- Hits               64438   64267    -171     
- Misses             13928   13957     +29     
  Partials               9       9

Files with missing lines	Coverage Δ
include/xrpl/ledger/ApplyView.h	`97.1% <ø> (ø)`
include/xrpl/ledger/View.h	`100.0% <ø> (ø)`
include/xrpl/ledger/helpers/EscrowHelpers.h	`98.9% <100.0%> (+<0.1%)`	⬆️
include/xrpl/ledger/helpers/RippleStateHelpers.h	`100.0% <ø> (ø)`
include/xrpl/ledger/helpers/SponsorHelpers.h	`97.8% <100.0%> (-0.1%)`	⬇️
include/xrpl/tx/ApplyContext.h	`100.0% <100.0%> (ø)`
.../xrpl/tx/transactors/token/MPTokenIssuanceCreate.h	`100.0% <ø> (ø)`
src/libxrpl/ledger/View.cpp	`96.8% <100.0%> (+0.1%)`	⬆️
src/libxrpl/ledger/helpers/MPTokenHelpers.cpp	`96.5% <100.0%> (+0.1%)`	⬆️
src/libxrpl/ledger/helpers/RippleStateHelpers.cpp	`92.9% <100.0%> (+<0.1%)`	⬆️
... and 25 more

... and 13 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

… mvadari/sponsor/apply-view-context

xrplf-ai-reviewer

No issues.

Review by Claude Sonnet 4.6 · Prompt: V15

Copilot

Pull request overview

Refactors transaction application helpers and transactors to pass a unified ApplyViewContext (view + tx) instead of separate ApplyView and STTx parameters, aiming to simplify call sites and reduce parameter threading across the tx/ledger helper layer.

Changes:

Introduces ApplyViewContext and updates many helper APIs (doWithdraw, token/escrow/sponsor helpers, etc.) to take it.
Adds ApplyContext::getApplyViewContext() and updates many transactors to use it.
Updates internal implementations to read ctx.view / ctx.tx instead of separate parameters.

Reviewed changes

Copilot reviewed 38 out of 38 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
src/libxrpl/tx/transactors/vault/VaultWithdraw.cpp	Switches helper calls to pass `ctx_.getApplyViewContext()` instead of `(view(), ctx_.tx)`.
src/libxrpl/tx/transactors/vault/VaultDeposit.cpp	Updates MPToken authorization/enforcement calls to use `ApplyViewContext`.
src/libxrpl/tx/transactors/vault/VaultDelete.cpp	Updates holding removal calls to use `ApplyViewContext`.
src/libxrpl/tx/transactors/vault/VaultCreate.cpp	Updates empty-holding creation and MPToken issuance/authorization to use `ApplyViewContext`.
src/libxrpl/tx/transactors/vault/VaultClawback.cpp	Updates holding removal to use `ApplyViewContext`.
src/libxrpl/tx/transactors/token/TrustSet.cpp	Uses `getTxReserveSponsor(ctx_.getApplyViewContext())`.
src/libxrpl/tx/transactors/token/MPTokenIssuanceCreate.cpp	Changes `create()` signature to accept `ApplyViewContext&` and updates sponsor lookup.
src/libxrpl/tx/transactors/token/MPTokenAuthorize.cpp	Updates `authorizeMPToken` call to use `ApplyViewContext`.
src/libxrpl/tx/transactors/Sponsor/SponsorshipSet.cpp	Updates sponsor lookup to use `ApplyViewContext`.
src/libxrpl/tx/transactors/payment/DepositPreauth.cpp	Updates sponsor lookup to use `ApplyViewContext` in reserve checks.
src/libxrpl/tx/transactors/payment_channel/PaymentChannelFund.cpp	Updates sponsor lookup to use `ApplyViewContext`.
src/libxrpl/tx/transactors/payment_channel/PaymentChannelCreate.cpp	Updates sponsor lookup to use `ApplyViewContext`.
src/libxrpl/tx/transactors/lending/LoanSet.cpp	Updates `addEmptyHolding` calls to use `ApplyViewContext`.
src/libxrpl/tx/transactors/lending/LoanPay.cpp	Updates `addEmptyHolding` calls to use `ApplyViewContext`.
src/libxrpl/tx/transactors/lending/LoanBrokerSet.cpp	Updates `addEmptyHolding` calls to use `ApplyViewContext`.
src/libxrpl/tx/transactors/lending/LoanBrokerDelete.cpp	Updates `removeEmptyHolding` call to use `ApplyViewContext`.
src/libxrpl/tx/transactors/lending/LoanBrokerCoverWithdraw.cpp	Updates `doWithdraw` call to use `ApplyViewContext`.
src/libxrpl/tx/transactors/escrow/EscrowFinish.cpp	Updates escrow unlock helper call to use `ApplyViewContext`.
src/libxrpl/tx/transactors/escrow/EscrowCreate.cpp	Updates sponsor lookup to use `ApplyViewContext`.
src/libxrpl/tx/transactors/escrow/EscrowCancel.cpp	Updates escrow unlock helper call to use `ApplyViewContext`.
src/libxrpl/tx/transactors/delegate/DelegateSet.cpp	Updates sponsor lookup to use `ApplyViewContext`.
src/libxrpl/tx/transactors/check/CheckCreate.cpp	Updates sponsor lookup to use `ApplyViewContext`.
src/libxrpl/tx/transactors/check/CheckCash.cpp	Introduces a local `ApplyViewContext` for sponsor lookup.
src/libxrpl/tx/transactors/account/SignerListSet.cpp	Updates sponsor lookup to use `ApplyViewContext`.
src/libxrpl/tx/ApplyContext.cpp	Constructs/stores `viewCtx_` and initializes `view_` in the initializer list.
src/libxrpl/ledger/View.cpp	Changes `doWithdraw` to accept `ApplyViewContext&` and routes through `ctx.view`/`ctx.tx`.
src/libxrpl/ledger/helpers/TokenHelpers.cpp	Updates asset-dispatching helpers to accept `ApplyViewContext&`.
src/libxrpl/ledger/helpers/RippleStateHelpers.cpp	Updates IOU trustline holding helpers to accept `ApplyViewContext&`.
src/libxrpl/ledger/helpers/MPTokenHelpers.cpp	Updates MPToken holding/auth helpers to accept `ApplyViewContext&` and use `ctx.tx`.
include/xrpl/tx/transactors/token/MPTokenIssuanceCreate.h	Public header signature change: `create(ApplyViewContext&, ...)`.
include/xrpl/tx/ApplyContext.h	Adds `getApplyViewContext()` and stores an `ApplyViewContext` member.
include/xrpl/ledger/View.h	Public header signature change: `doWithdraw(ApplyViewContext&, ...)`.
include/xrpl/ledger/helpers/TokenHelpers.h	Public header signature changes for add/remove empty holdings.
include/xrpl/ledger/helpers/SponsorHelpers.h	Public header signature change: `getTxReserveSponsor(ApplyViewContext&)`.
include/xrpl/ledger/helpers/RippleStateHelpers.h	Public header signature changes to accept `ApplyViewContext&`.
include/xrpl/ledger/helpers/MPTokenHelpers.h	Public header signature changes to accept `ApplyViewContext&`.
include/xrpl/ledger/helpers/EscrowHelpers.h	Public header template signature changes to accept `ApplyViewContext&`.
include/xrpl/ledger/ApplyView.h	Introduces the `ApplyViewContext` struct type.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

xrplf-ai-reviewer

Clean refactor. LGTM.

Review by Claude Sonnet 4.6 · Prompt: V15

xrplf-ai-reviewer

Clean refactor — no concerns.

Review by Claude Sonnet 4.6 · Prompt: V15

mvadari · 2026-06-26T20:44:16Z

Converting to Draft to avoid CI being run, this is still ready for review

github-actions · 2026-06-29T15:44:08Z

This PR has conflicts, please resolve them in order for the PR to be reviewed.

xrplf-ai-reviewer

No issues.

Review by Claude Sonnet 4.6 · Prompt: V15

Copilot

Pull request overview

Copilot reviewed 37 out of 37 changed files in this pull request and generated 3 comments.

xrplf-ai-reviewer

No issues.

Review by Claude Sonnet 4.6 · Prompt: V15

oleks-rip · 2026-06-29T17:52:40Z

-        if (auto const ret =
-                checkInsufficientReserve(view, tx, sleDest, xrpBalance, *sponsorSle, 1, 0, journal);
+        if (auto const ret = checkInsufficientReserve(
+                view, ctx.tx, sleDest, xrpBalance, *sponsorSle, 1, 0, journal);


so this should be changed too, like getTxReserveSponsor

Yes, agreed. However, we can't do that in this PR - it currently takes a ReadView because it's called in preclaim in one place, so that needs to be fixed (in a separate PR) first.

Will do after #7667, possibly in #7661

oleks-rip · 2026-06-29T18:15:10Z


+struct ApplyViewContext
+{
+    ApplyView& view;


you should disable copy constructors

I tried this, it doesn't work because we're passing by value not reference so we are copying

better to disable copy constructors and pass it by right reference, or forgotten copy can appear somewhere

xrplf-ai-reviewer

Clean refactor — nothing to flag.

Review by Claude Sonnet 4.6 · Prompt: V15

This reverts commit 9485c3c.

xrplf-ai-reviewer

No issues.

Review by Claude Sonnet 4.6 · Prompt: V15

xrplf-ai-reviewer

No issues.

Review by Claude Sonnet 4.6 · Prompt: V15

xrplf-ai-reviewer

Clean refactor — no issues.

Review by Claude Sonnet 4.6 · Prompt: V15

xrplf-ai-reviewer

Clean refactor — no issues.

Review by Claude Sonnet 4.6 · Prompt: V15

… mvadari/sponsor/apply-view-context

xrplf-ai-reviewer

No issues.

Review by Claude Sonnet 4.6 · Prompt: V15

xrplf-ai-reviewer

No issues.

Review by Claude Sonnet 4.6 · Prompt: V15

xrplf-ai-reviewer

No issues.

Review by Claude Sonnet 4.6 · Prompt: V15

xrplf-ai-reviewer

No issues.

Review by Claude Sonnet 4.6 · Prompt: V15

xrplf-ai-reviewer

Clean refactor — no issues.

Review by Claude Sonnet 4.6 · Prompt: V15

PoC: ApplyViewContext

b6e1b33

mvadari added the DraftRunCI Normally CI does not run on draft PRs. This opts in. label Jun 24, 2026

mvadari added 2 commits June 24, 2026 19:52

reduce diff

20eaf5c

fix build issue

1a2a7e9

Tapanito reviewed Jun 25, 2026

View reviewed changes

Comment thread include/xrpl/ledger/helpers/MPTokenHelpers.h

mvadari added 4 commits June 25, 2026 22:16

pass by reference

88ae2bb

Merge branch 'xrplf/sponsor' of https://github.com/XRPLF/rippled into…

bcb3de1

… mvadari/sponsor/apply-view-context

implement the rest of it

00fc081

shrink diff

7644970

mvadari marked this pull request as ready for review June 26, 2026 15:52

Copilot AI review requested due to automatic review settings June 26, 2026 15:52

mvadari removed the DraftRunCI Normally CI does not run on draft PRs. This opts in. label Jun 26, 2026

mvadari changed the title ~~PoC: ApplyViewContext~~ refactor: Use ApplyViewContext everywhere instead of ApplyView+STTx Jun 26, 2026

Copilot started reviewing on behalf of mvadari June 26, 2026 15:52 View session

xrplf-ai-reviewer Bot approved these changes Jun 26, 2026

View reviewed changes

Copilot AI reviewed Jun 26, 2026

View reviewed changes

Comment thread src/libxrpl/tx/ApplyContext.cpp Outdated

Comment thread include/xrpl/tx/transactors/token/MPTokenIssuanceCreate.h Outdated

add assert

6947d41

xrplf-ai-reviewer Bot approved these changes Jun 26, 2026

View reviewed changes

oleks-rip reviewed Jun 26, 2026

View reviewed changes

Comment thread src/libxrpl/tx/transactors/check/CheckCash.cpp Outdated

oleks-rip reviewed Jun 26, 2026

View reviewed changes

Comment thread include/xrpl/tx/ApplyContext.h Outdated

oleks-rip reviewed Jun 26, 2026

View reviewed changes

Comment thread src/libxrpl/tx/ApplyContext.cpp Outdated

fix build

b591bfe

xrplf-ai-reviewer Bot approved these changes Jun 26, 2026

View reviewed changes

mvadari marked this pull request as draft June 26, 2026 20:44

clang-tidy I hope you get a rock in your shoe

02cc200

github-actions Bot added the PR: has conflicts label Jun 29, 2026

mvadari marked this pull request as ready for review June 29, 2026 15:44

Copilot started reviewing on behalf of mvadari June 29, 2026 15:54 View session

xrplf-ai-reviewer Bot approved these changes Jun 29, 2026

View reviewed changes

Copilot AI reviewed Jun 29, 2026

View reviewed changes

Comment thread include/xrpl/ledger/ApplyView.h

Comment thread include/xrpl/ledger/helpers/SponsorHelpers.h

Comment thread include/xrpl/ledger/helpers/TokenHelpers.h

clang-tidy go get stung by a bee

2759dfb

xrplf-ai-reviewer Bot approved these changes Jun 29, 2026

View reviewed changes

oleks-rip reviewed Jun 29, 2026

View reviewed changes

mvadari and others added 2 commits June 29, 2026 14:20

disable copy constructors

9485c3c

Merge branch 'xrplf/sponsor' into mvadari/sponsor/apply-view-context

aee7651

xrplf-ai-reviewer Bot approved these changes Jun 29, 2026

View reviewed changes

Revert "disable copy constructors"

4a3a247

This reverts commit 9485c3c.

xrplf-ai-reviewer Bot approved these changes Jun 29, 2026

View reviewed changes

mvadari mentioned this pull request Jun 29, 2026

refactor: Switch checkInsufficientReserve from ReadView to ApplyView #7667

Open

Merge branch 'xrplf/sponsor' into mvadari/sponsor/apply-view-context

c710a8a

xrplf-ai-reviewer Bot approved these changes Jun 29, 2026

View reviewed changes

use reference in helper functions

b8ae7a2

xrplf-ai-reviewer Bot approved these changes Jun 29, 2026

View reviewed changes

mvadari added 2 commits June 29, 2026 17:35

fix build issues

f005879

missed one

13aff69

xrplf-ai-reviewer Bot approved these changes Jun 29, 2026

View reviewed changes

Merge branch 'xrplf/sponsor' of https://github.com/XRPLF/rippled into…

ad4abab

… mvadari/sponsor/apply-view-context

xrplf-ai-reviewer Bot approved these changes Jun 29, 2026

View reviewed changes

cmon clang-tidy gimme a break

4395da1

xrplf-ai-reviewer Bot approved these changes Jun 29, 2026

View reviewed changes

switch to &&

8f470b7

xrplf-ai-reviewer Bot approved these changes Jun 29, 2026

View reviewed changes

f u clang-tidy

c7a3abb

xrplf-ai-reviewer Bot approved these changes Jun 29, 2026

View reviewed changes

fix clang-tidy

4cbc050

xrplf-ai-reviewer Bot approved these changes Jun 30, 2026

View reviewed changes

Uh oh!

Conversation

mvadari commented Jun 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

High Level Overview of Change

Context of Change

Future Tasks

Uh oh!

codecov Bot commented Jun 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

xrplf-ai-reviewer Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

xrplf-ai-reviewer Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

xrplf-ai-reviewer Bot left a comment

Choose a reason for hiding this comment

Uh oh!

mvadari commented Jun 26, 2026

Uh oh!

github-actions Bot commented Jun 29, 2026

Uh oh!

xrplf-ai-reviewer Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

xrplf-ai-reviewer Bot left a comment

Choose a reason for hiding this comment

Uh oh!

oleks-rip Jun 29, 2026

Choose a reason for hiding this comment

Uh oh!

mvadari Jun 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mvadari Jun 29, 2026

Choose a reason for hiding this comment

Uh oh!

oleks-rip Jun 29, 2026

Choose a reason for hiding this comment

Uh oh!

mvadari Jun 29, 2026

Choose a reason for hiding this comment

Uh oh!

mvadari Jun 29, 2026

Choose a reason for hiding this comment

Uh oh!

oleks-rip Jun 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

xrplf-ai-reviewer Bot left a comment

Choose a reason for hiding this comment

Uh oh!

xrplf-ai-reviewer Bot left a comment

Choose a reason for hiding this comment

Uh oh!

xrplf-ai-reviewer Bot left a comment

Choose a reason for hiding this comment

mvadari commented Jun 24, 2026 •

edited

Loading

codecov Bot commented Jun 25, 2026 •

edited

Loading

mvadari Jun 29, 2026 •

edited

Loading

oleks-rip Jun 29, 2026 •

edited

Loading