Fix fetch_info clear parameter type validation (#6756)#7606
Open
harshitgupta62 wants to merge 1 commit into
Open
Fix fetch_info clear parameter type validation (#6756)#7606harshitgupta62 wants to merge 1 commit into
harshitgupta62 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes an issue where the
clearparameter in thefetch_infoRPC method accepts non-boolean values due to loose type coercion.Problem
The current implementation uses
asBool()directly, which coerces non-boolean JSON values into boolean. This leads to unintended behavior where inputs like:{ "clear": "false" }{ "clear": [1] }{ "clear": {} }are treated as
true, causingclearLedgerFetch()to be triggered unexpectedly.Solution
Added strict type validation using
isBool()before callingasBool(). Now, only an explicit booleantruevalue will trigger the clearing of ledger fetch state.Behavior After Fix
{ "clear": true }→ clears fetch state{ "clear": false }→ does not clearImpact
Related Issue
Closes #6756