fix: Check credential for LoanBrokerCoverWithdraw and VaultWithdraw#7107
fix: Check credential for LoanBrokerCoverWithdraw and VaultWithdraw#7107shawnxie999 wants to merge 14 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #7107 +/- ##
=========================================
- Coverage 82.4% 82.4% -0.0%
=========================================
Files 1011 1011
Lines 76913 76952 +39
Branches 8962 8964 +2
=========================================
+ Hits 63348 63375 +27
- Misses 13556 13568 +12
Partials 9 9
🚀 New features to boost your workflow:
|
|
This PR has conflicts, please resolve them in order for the PR to be reviewed. |
|
All conflicts have been resolved. Assigned reviewers can now start or resume their review. |
|
This PR has conflicts, please resolve them in order for the PR to be reviewed. |
|
All conflicts have been resolved. Assigned reviewers can now start or resume their review. |
|
This PR has conflicts, please resolve them in order for the PR to be reviewed. |
|
All conflicts have been resolved. Assigned reviewers can now start or resume their review. |
|
This PR has conflicts, please resolve them in order for the PR to be reviewed. |
High Level Overview of Change
Context of Change
VaultWithdrawandLoanBrokerCoverWithdrawdid not acceptsfCredentialIDs, so withdrawals to a destination withlsfDepositAuthand credential-only preauth failed withtecNO_PERMISSIONeven when the sender held valid credentials.Fix
Add
sfCredentialIDsto both transaction formats and wire up credential validation, following the pattern used byPayment. Gated byfixCleanup3_2_0(withfeatureCredentialsfor the field).Spec update: XRPLF/XRPL-Standards#538
API Impact
libxrplchange (any change that may affectlibxrplor dependents oflibxrpl)