DRAFT: Try 2^63-1 mantissa range refactoring on asan branch#6292
Draft
ximinez wants to merge 19 commits into
Draft
DRAFT: Try 2^63-1 mantissa range refactoring on asan branch#6292ximinez wants to merge 19 commits into
ximinez wants to merge 19 commits into
Conversation
- That makes minMantissa 2^63/10+1. - Simplifies many of the existing operations, and removes the need for the accessors (mantissa() & exponent()) to do any math.
ximinez
added
the
DraftRunCI
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## pratik/Fix_asan_lsan_flagged_issues #6292 +/- ##
=====================================================================
- Coverage 79.8% 79.8% -0.0%
=====================================================================
Files 846 846
Lines 67771 67781 +10
Branches 7557 7567 +10
=====================================================================
- Hits 54072 54066 -6
- Misses 13699 13715 +16
... and 6 files with indirect coverage changes 🚀 New features to boost your workflow:
|
…es' into ximinez/number_asan * XRPLF/pratik/Fix_asan_lsan_flagged_issues: fixed asan escape macro before return type added comments and haltonerror=false remove suppressions fix memory leak in LocalValue run parallel tests Don't copy the Json::StaticString fixes to static variable destruction issue. fix: Deletes expired NFToken offers from ledger (5707) chore: Add .zed editor config directory to .gitignore (6317) clang-format updates ssl context cleanup. docs: Update API changelog, add APIv2+APIv3 version documentation (6308) fix: Restore config changes that broke standalone mode (6301) chore: Add upper-case match for ARM64 in CompilationEnv (6315) ci: Update hashes of XRPLF/actions (6316) chore: Format all cmake files without comments (6294) chore: Add cmake-format pre-commit hook (6279) chore: Remove unnecessary `boost::system` requirement from conanfile (6290) chore: Set ColumnLimit to 120 in clang-format (6288) run tests in serial
…es' into ximinez/number_asan * XRPLF/pratik/Fix_asan_lsan_flagged_issues: (61 commits) Apply suggestion from @pratikmankawde refactor: Modularize app/tx (6228) do not fix the stack size refactor: Decouple app/tx from `Application` and `Config` (6227) increase timeout chore: Update clang-format to 21.1.8 (6352) reverted change in Number halt on error = 0 remove printXXX from asan rt args remove symbolize option from asan only run asan supp. coro releated asan errors run sanitizer tests in parallel refactor: Modularize `HashRouter`, `Conditions`, and `OrderBookDB` (6226) increase timeout for sanitizer jobs chore: Fix minor issues in comments (6346) refactor: Modularize the NetworkOPs interface (6225) removing timeout changes increase timeout for sanitizer builds, since we are seeing timeouts increase stack size of coroutine ...
…number_asan * commit '25cca465538a56cce501477f9e5e2c1c7ea2d84c': chore: Set clang-format width to 100 in config file (6387) chore: Set cmake-format width to 100 (6386) ci: Add clang tidy workflow to ci (6369)
* commit '2c1fad1023': chore: Apply clang-format width 100 (6387)
…number_asan * commit 'd03d72bfd57a76b4f4ec9259a851ef52271618cf': ci: Add dependabot config (6379) Fix tautological assertion (6393)
…number_asan * commit 'd9f54113b3c445c32e306ec6c895b469ca30ae77':
…es' into ximinez/number_asan * XRPLF/pratik/Fix_asan_lsan_flagged_issues: add supp for gcc increase timeout
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
Combines #6150 and #6275.
Context of Change
Type of Change
.gitignore, formatting, dropping support for older tooling)API Impact
libxrplchange (any change that may affectlibxrplor dependents oflibxrpl)