Skip to content

ci: Pin scylladb docker to fix integration tests#3126

Merged
mathbunnyru merged 1 commit into
XRPLF:developfrom
mathbunnyru:pin_scylladb
Jun 30, 2026
Merged

ci: Pin scylladb docker to fix integration tests#3126
mathbunnyru merged 1 commit into
XRPLF:developfrom
mathbunnyru:pin_scylladb

Conversation

@mathbunnyru

Copy link
Copy Markdown
Collaborator

It seems that new scylladb versions have changed SimpleStrategy that we use and now code fails with:

C++ exception with description "Could not create keyspace: future::get(): SimpleStrategy doesn't support tablet replication" thrown in the test fixture's constructor.

This should fix it for now in integration tests, but we should take a closer look if we need to migrate the database

@codecov

codecov Bot commented Jun 30, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.61%. Comparing base (3073288) to head (f51a501).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3126   +/-   ##
========================================
  Coverage    82.61%   82.61%           
========================================
  Files          397      397           
  Lines        16034    16034           
  Branches      8399     8399           
========================================
+ Hits         13246    13247    +1     
  Misses        1667     1667           
+ Partials      1121     1120    -1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@godexsoft godexsoft left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should be careful with scylla and their driver.. we have seen that updating the driver also broke things last time we tried. My understanding is that this change is pinning the older version, right?

@mathbunnyru

Copy link
Copy Markdown
Collaborator Author

We should be careful with scylla and their driver.. we have seen that updating the driver also broke things last time we tried. My understanding is that this change is pinning the older version, right?

Yes, it's pinning the version before the latest release, which broke something.
And this change is tests-only, no effect on production.

@mathbunnyru mathbunnyru merged commit c2b129b into XRPLF:develop Jun 30, 2026
127 of 130 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants